[release-4.20] OCPBUGS-78295: Fix editing secrets with mixed text and binary data by openshift-cherrypick-robot · Pull Request #16132 · openshift/console

openshift-cherrypick-robot · 2026-03-11T19:53:34Z

This is an automated cherry-pick of #16060

/assign TheRealJon

When a secret contained both text and binary values, the edit form would fail due to a runtime error. The stringData initialization was returning null when any binary field was detected, breaking text field handling. Now binary fields are skipped during stringData initialization while text fields are preserved, allowing proper editing of mixed-type secrets. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

coderabbitai · 2026-03-11T19:53:46Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ae0ba628-90f5-43b8-b4b6-1872902fad9c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-03-11T19:53:47Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-77251 has been cloned as Jira Issue OCPBUGS-78295. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-78295: Fix editing secrets with mixed text and binary data

Details

In response to this:

This is an automated cherry-pick of #16060

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-11T19:53:56Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-78295, which is invalid:

expected dependent Jira Issue OCPBUGS-77251 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #16060

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2026-03-13T12:38:08Z

/retest-required

TheRealJon · 2026-03-13T13:32:22Z

/label backport-risk-assessed
/lgtm

yanpzhan · 2026-03-18T11:00:13Z

Checked on cluster launched against the pr. Created a secret containing both a text value and an image value. Then edited the secret from console, the secret could be edit successfully, there was not error.
/verified by yanpzhan

openshift-ci-robot · 2026-03-18T11:00:27Z

@yanpzhan: This PR has been marked as verified by yanpzhan.

Details

In response to this:

Checked on cluster launched against the pr. Created a secret containing both a text value and an image value. Then edited the secret from console, the secret could be edit successfully, there was not error.
/verified by yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

TheRealJon · 2026-03-19T13:31:14Z

/label backport-risk-assessed
/lgtm

openshift-ci · 2026-03-19T13:35:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [TheRealJon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Leo6Leo · 2026-03-19T14:36:36Z

/retest-required

TheRealJon · 2026-03-20T15:04:33Z

/retest

TheRealJon · 2026-03-25T13:10:39Z

/jira refresh

openshift-ci-robot · 2026-03-25T13:10:49Z

@TheRealJon: This pull request references Jira Issue OCPBUGS-78295, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-77251 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-77251 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2026-03-25T21:27:40Z

/retest-required

Leo6Leo · 2026-03-26T12:54:21Z

/retest-required

openshift-ci-robot · 2026-03-26T15:04:49Z

/retest-required

Remaining retests: 0 against base HEAD 0428a9d and 2 for PR HEAD c3cd63b in total

openshift-ci-robot · 2026-03-27T01:04:11Z

/retest-required

Remaining retests: 0 against base HEAD 5ad72a8 and 1 for PR HEAD c3cd63b in total

Leo6Leo · 2026-03-27T13:39:46Z

/retest-required

Leo6Leo · 2026-03-30T17:02:51Z

/retest-required

Leo6Leo · 2026-03-30T20:42:12Z

/retest-required

Leo6Leo · 2026-03-31T13:56:35Z

/retest-required

Leo6Leo · 2026-03-31T17:29:36Z

/retest-required

openshift-ci-robot · 2026-04-01T07:22:09Z

/retest-required

Remaining retests: 0 against base HEAD 1941562 and 0 for PR HEAD c3cd63b in total

Leo6Leo · 2026-04-01T13:27:25Z

/retest-required

Leo6Leo · 2026-04-01T19:09:04Z

/retest-required

openshift-ci · 2026-04-02T01:44:33Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-04-02T01:49:28Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-78295
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-78295 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #16060

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot assigned TheRealJon Mar 11, 2026

openshift-cherrypick-robot mentioned this pull request Mar 11, 2026

[release-4.21] OCPBUGS-77251: Fix editing secrets with mixed text and binary data #16060

Merged

openshift-ci bot changed the title ~~[release-4.20] OCPBUGS-77251: Fix editing secrets with mixed text and binary data~~ [release-4.20] OCPBUGS-78295: Fix editing secrets with mixed text and binary data Mar 11, 2026

openshift-ci bot requested review from Leo6Leo and rhamilto March 11, 2026 19:53

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Mar 11, 2026

openshift-ci bot added the component/core Related to console core functionality label Mar 11, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 11, 2026

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 13, 2026

openshift-ci bot assigned sanketpathak, XiyunZhao, yanpzhan and yapei Mar 13, 2026

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 18, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2026

openshift-ci bot requested a review from yapei March 25, 2026 13:10

openshift-merge-bot bot merged commit 3a13a7d into openshift:release-4.20 Apr 2, 2026
7 checks passed

Conversation

openshift-cherrypick-robot commented Mar 11, 2026

Uh oh!

coderabbitai bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci-robot commented Mar 11, 2026

Uh oh!

openshift-ci-robot commented Mar 11, 2026

Uh oh!

Leo6Leo commented Mar 13, 2026

Uh oh!

TheRealJon commented Mar 13, 2026

Uh oh!

yanpzhan commented Mar 18, 2026

Uh oh!

openshift-ci-robot commented Mar 18, 2026

Uh oh!

TheRealJon commented Mar 19, 2026

Uh oh!

openshift-ci bot commented Mar 19, 2026

Uh oh!

Leo6Leo commented Mar 19, 2026

Uh oh!

TheRealJon commented Mar 20, 2026

Uh oh!

TheRealJon commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

Leo6Leo commented Mar 25, 2026

Uh oh!

Leo6Leo commented Mar 26, 2026

Uh oh!

openshift-ci-robot commented Mar 26, 2026

Uh oh!

openshift-ci-robot commented Mar 27, 2026

Uh oh!

Leo6Leo commented Mar 27, 2026

Uh oh!

Leo6Leo commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 31, 2026

Uh oh!

Leo6Leo commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Apr 1, 2026

Uh oh!

Leo6Leo commented Apr 1, 2026

Uh oh!

Leo6Leo commented Apr 1, 2026

Uh oh!

openshift-ci bot commented Apr 2, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

coderabbitai bot commented Mar 11, 2026 •

edited

Loading