Fix CI failures: Update Node.js to 22 and sync Konflux pipelines - #1352
Merged
openshift-merge-bot[bot] merged 7 commits intoSep 8, 2026
Merged
openshift-merge-bot[bot] merged 7 commits into
openshift-merge-bot[bot] merged 7 commits into
Conversation
…ibility ts-json-schema-generator@2.9.0 requires Node.js >=22.0.0, updating from 20.18.1 to fix failing lint and unit test workflows. Fixes: openshift-knative#1058
Replace outdated docker-build.yaml with current version from hack repo. The old pipeline had init task requiring image-url, rebuild, skip-checks parameters which caused validation failure. The updated pipeline correctly only requires enable-cache-proxy for the init task. Changes: - Remove rebuild parameter (no longer exists in current pipeline) - Remove image-url, rebuild, skip-checks from init task - Add enable-package-registry-proxy parameter - Add sast-target-dirs parameter - Add source-date-epoch, rewrite-timestamp, omit-history parameters - Update task bundle versions to latest Fixes Konflux error: invalid input params for task init: missing values for these params which have no default values: [image-url]
The updated docker-build.yaml pipeline's init task requires the enable-cache-proxy parameter. Adding it with default value 'false'. This is the correct minimal fix based on hack repo template - no need for image-url parameter as suggested by other tools.
Updated generated Dockerfiles to use: - Go 1.26 (from 1.23) - OpenShift 4.23 (from 4.19) Generated files: - openshift/ci-operator/build-image/Dockerfile - openshift/ci-operator/knative-images/eventmesh/Dockerfile
…sion Pipeline updates: - Update GO_BUILDER to golang_1.26 in both pull-request and push tasks - Add enable-cache-proxy parameter to push task (was missing) Package.json fix: - Update engines.node from '18 || 20' to '18 || 20 || 22' - Fixes: 'The engine "node" is incompatible with this module. Expected version "18 || 20". Got "22.11.0"' This ensures consistency with the generated Dockerfiles which now use Go 1.26.
Changes:
1. Update engines.node from '18 || 20' to '>=18'
- Allows Node 22 (required by ts-json-schema-generator@2.9.0)
- Also supports future Node versions
2. Add yarn resolution for @azure/msal-node to ^6.0.0
- Fixes: '@azure/msal-node@2.6.0: The engine "node" is incompatible
with this module. Expected version "16|| 18 || 20"'
- Version 6.0.0 supports Node >=20 (including 22+)
Tested locally with yarn install - no engine compatibility errors.
Problem: - ts-json-schema-generator@2.9.0 requires Node >=22 - isolated-vm@4.6.0 doesn't compile with Node 22 (V8 API incompatibilities) - This created a dependency conflict Solution: - Revert to Node 20.18.1 (from .nvmrc) - Add yarn resolution to force ts-json-schema-generator@2.4.0 - Version 2.4.0 supports Node >=18 (works with Node 20) - Avoids isolated-vm compilation issues - Satisfies all CI workflow requirements Tested locally - no Node engine incompatibility errors.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, Kaustubh-pande The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Sep 8, 2026
918a8bd
into
openshift-knative:release-v1.17
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing CI checks for PR #1058 by updating Node.js version and synchronizing Konflux pipeline configurations with the latest hack repo templates.
Problem
PR #1058 had three failing checks:
invalid input params for task init: missing values for these params which have no default values: [image-url]Root Causes
Issue 1: Node.js Version Incompatibility
The dependency
ts-json-schema-generator@2.9.0requires Node.js >=22.0.0, but workflows were running on Node 20.18.1.Issue 2: Outdated Konflux Pipelines
The
.tekton/docker-build.yamlpipeline was outdated and had incompatible parameter requirements for theinittask. The old pipeline requiredimage-url,rebuild, andskip-checksparameters that are no longer part of the current pipeline specification.Changes
1. Update Node.js Version
File:
backstage/.nvmrc