Skip to content

8373945: Use WB.fullGC() in ClassUnloader.unloadClass to force GC for vmTestbase tests#199

Open
sendaoYan wants to merge 7 commits into
openjdk:masterfrom
sendaoYan:jbs8373945
Open

8373945: Use WB.fullGC() in ClassUnloader.unloadClass to force GC for vmTestbase tests#199
sendaoYan wants to merge 7 commits into
openjdk:masterfrom
sendaoYan:jbs8373945

Conversation

@sendaoYan

@sendaoYan sendaoYan commented Jan 29, 2026

Copy link
Copy Markdown
Member

Hi all,

This backport PR contains JDK-8373945 and JDK-8375485. These two PR try to use WB.fullGC() in ClassUnloader.unloadClass to force GC for vmTestbase tests, which will make test more robustness and run more quickly. Some of the tests touched by '8260555: Change the default TIMEOUT_FACTOR from 4 to 1' make this backport uncleanly, and only below 5 files backported uncleanly because of the diffrent copyright year. All other parts are cleanly.

Change has been verifed locally on linux-x64 by run all the releated tests. Test-fix only, no risk.

test/hotspot/jtreg/vmTestbase/gc/gctests/LargeObjects/large001/large001.java
test/hotspot/jtreg/vmTestbase/gc/gctests/LargeObjects/large002/TestDescription.java
test/hotspot/jtreg/vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java
test/hotspot/jtreg/vmTestbase/gc/gctests/LargeObjects/large004/TestDescription.java
test/hotspot/jtreg/vmTestbase/gc/gctests/LargeObjects/large005/TestDescription.java

Related tests list:

199.log



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8373945 needs maintainer approval
  • JDK-8375485 needs maintainer approval

Error

 ⚠️ OCA signatory status must be verified

Issues

  • JDK-8373945: Use WB.fullGC() in ClassUnloader.unloadClass to force GC for vmTestbase tests (Enhancement - P4)
  • JDK-8375485: Tests in vmTestbase/nsk are failing due to missing class unloading after 8373945 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/199/head:pull/199
$ git checkout pull/199

Update a local copy of the PR:
$ git checkout pull/199
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 199

View PR using the GUI difftool:
$ git pr show -t 199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/199.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jan 29, 2026

Copy link
Copy Markdown

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jan 29, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport ce5e0d8a48296b51c9c2eff4867e2a9a70194091 8373945: Use WB.fullGC() in ClassUnloader.unloadClass to force GC for vmTestbase tests Jan 29, 2026
@openjdk

openjdk Bot commented Jan 29, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Jan 29, 2026
@sendaoYan sendaoYan marked this pull request as ready for review January 29, 2026 07:41
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jan 29, 2026
@mlbridge

mlbridge Bot commented Jan 29, 2026

Copy link
Copy Markdown

Webrevs

@sendaoYan

sendaoYan commented Jan 29, 2026

Copy link
Copy Markdown
Member Author

/issue JDK-8375485

@openjdk

openjdk Bot commented Jan 29, 2026

Copy link
Copy Markdown

@sendaoYan
Adding additional issue to issue list: 8375485: Tests in vmTestbase/nsk are failing due to missing class unloading after 8373945.

@bridgekeeper

bridgekeeper Bot commented Apr 6, 2026

Copy link
Copy Markdown

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper

bridgekeeper Bot commented May 5, 2026

Copy link
Copy Markdown

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan

sendaoYan commented May 6, 2026

Copy link
Copy Markdown
Member Author

/template append

@openjdk

openjdk Bot commented May 6, 2026

Copy link
Copy Markdown

@sendaoYan The pull request template has been appended to the pull request body

@openjdk openjdk Bot removed the rfr Pull request is ready for review label May 6, 2026
@openjdk openjdk Bot added the rfr Pull request is ready for review label May 6, 2026
@bridgekeeper bridgekeeper Bot added the oca Needs verification of OCA signatory status label May 28, 2026
@openjdk openjdk Bot removed the rfr Pull request is ready for review label May 28, 2026
@bridgekeeper

bridgekeeper Bot commented Jun 26, 2026

Copy link
Copy Markdown

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base oca Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

1 participant