Repository navigation
1360 use inline static and constexpr in the library - #1396
Open
dsuponitskiy wants to merge 4 commits into
Open
dsuponitskiy wants to merge 4 commits into
dsuponitskiy wants to merge 4 commits into
Conversation
- Convert trivially defined static members to C++17 inline members, using constexpr where possible, across core and PKE. - Move FTT, Bluestein, and arbitrary-transform caches into headers for all four backends and remove their *-impl.h definitions. - Make implementation-only cache members private and add the required Bluestein friend declarations. - Remove the unused, undefined BigIntegerFixedT::m_modChain. - Keep PseudoRandomNumberGenerator::m_prng defined in the .cpp, as GCC rejects "pragma omp threadprivate" after an in-class definition.
Define StandardLatticeParmSets as an inline header member initialized by an out-of-line factory, keeping the large table initializer in one source file. Move GLOBALS::precomputeCRTTables into the header as a private inline static with friend accessors, and make the Log2, LogDtype, DataTypeChecker, and UIntBitWidth traits constexpr.
dsuponitskiy
force-pushed
the
1360-fix-a-build-error-in-generateinteger-new
branch
from
November 11, 2026 05:37
417b3a4 to
7093a03
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.