Skip to content

1360 use inline static and constexpr in the library - #1396

Open
dsuponitskiy wants to merge 4 commits into
devfrom
1360-fix-a-build-error-in-generateinteger-new
Open

dsuponitskiy wants to merge 4 commits into
devfrom
1360-fix-a-build-error-in-generateinteger-new

Conversation

@dsuponitskiy

Copy link
Copy Markdown
Collaborator

No description provided.

- Convert trivially defined static members to C++17 inline members, using constexpr where possible, across core and PKE.
- Move FTT, Bluestein, and arbitrary-transform caches into headers for all four backends and remove their *-impl.h definitions.
- Make implementation-only cache members private and add the required Bluestein friend declarations.
- Remove the unused, undefined BigIntegerFixedT::m_modChain.
- Keep PseudoRandomNumberGenerator::m_prng defined in the .cpp, as GCC rejects "pragma omp threadprivate" after an in-class definition.
Define StandardLatticeParmSets as an inline header member initialized by an out-of-line factory, keeping the large table initializer in one source file. Move GLOBALS::precomputeCRTTables into the header as a private inline static with friend accessors, and make the Log2, LogDtype, DataTypeChecker, and UIntBitWidth traits constexpr.
@dsuponitskiy dsuponitskiy added this to the Release 1.6.2 milestone Nov 11, 2026
@dsuponitskiy dsuponitskiy self-assigned this Nov 11, 2026
@dsuponitskiy dsuponitskiy changed the title 1360 fix a build error in generateinteger new 1360 use inline static and constexpr in the library Nov 11, 2026
@dsuponitskiy dsuponitskiy linked an issue Nov 11, 2026 that may be closed by this pull request
@dsuponitskiy
dsuponitskiy requested a review from pascoec November 11, 2026 05:35
@dsuponitskiy
dsuponitskiy force-pushed the 1360-fix-a-build-error-in-generateinteger-new branch from 417b3a4 to 7093a03 Compare November 11, 2026 05:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1360 Fix a build error in Generateinteger()

2 participants