Repository navigation
Fix CKKS composite scaling first modulus falling short of firstModSize - #1329
Open
dsuponitskiy wants to merge 4 commits into
Open
dsuponitskiy wants to merge 4 commits into
dsuponitskiy wants to merge 4 commits into
Conversation
The first-modulus loop charged its bit budget the requested size of each prime instead of the size actually sampled, so when the primes near a share were already taken the shortfall went unnoticed and accumulated: at ring dimension 16384 an 89-bit firstModSize produced a 75-bit modulus. The budget now follows the primes sampled, reaches above a share once primes of that size run out, releases the scaling primes it overwrites at multiplicative depth 0, and keeps the product below 2^firstModSize. Parameters that cannot reach firstModSize are reported instead of silently costing precision at the last level.
dsuponitskiy
force-pushed
the
1327-ckks-compositescalingauto-composite-modulus
branch
from
November 11, 2026 13:44
ad820d8 to
3142366
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first-modulus loop charged its bit budget the requested size of each prime instead of the size actually sampled, so when the primes near a share were already taken the shortfall went unnoticed and accumulated: at ring dimension 16384 an 89-bit firstModSize produced a 75-bit modulus. The budget now follows the primes sampled, reaches above a share once primes of that size run out, releases the scaling primes it overwrites at multiplicative depth 0, and keeps the product below 2^firstModSize. Parameters that cannot reach firstModSize are reported instead of silently costing precision at the last level.