libct: drop "from parent" from generic sync errors - #5433
Merged
Merged
Conversation
These messages date back to 4776b43 ("libcontainer: refactor syncT handling"), which added libcontainer/sync.go. Its readSync was used by "runc init" only, to read what its parent had sent, so saying "parent" was accurate. f81ef14 ("libcontainer: sync: cleanup synchronisation code") split readSync into doReadSync plus a few wrappers, and doReadSync now serves both sides: the child reaches it through readSync/readSyncFull, and the parent through parseSync. The wording was carried over unchanged, so ever since, a read error on the parent side claims runc failed to read from its parent, while it was in fact reading from "runc init". Both messages are equally clear without naming a side. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
AkihiroSuda
approved these changes
Sep 1, 2026
cyphar
approved these changes
Sep 3, 2026
cyphar
left a comment
cyphar
left a comment
Member
There was a problem hiding this comment.
LGTM. To be honest, I think I added these to aid in debugging way back then and ended up leaving them there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A drive-by spotted while working on #5431. TL;DR: correct (less confusing) error messages.
doReadSync's two error messages name a side:That used to be true. They arrive from 4776b43 ("libcontainer: refactor syncT handling", 2016), the commit that added
libcontainer/sync.go, wherereadSyncexisted forrunc initalone — reading what the parent had sent. Its sibling wording (invalid synchronisation flag from parent) was equally correct.f81ef14 ("libcontainer: sync: cleanup synchronisation code", 2023) split
readSyncintodoReadSyncplus wrappers, anddoReadSyncnow serves both sides: the child throughreadSync/readSyncFull, the parent throughparseSync. The text came along unchanged. So a read failure on the parent side has, since then, reported that runc could not read from its parent — while it was reading fromrunc init:Just drop the side; neither message needs it.