Skip to content

Fix duplicate folders and improve image caching performance#123

Open
zerox80 wants to merge 2 commits intoopencloud-eu:mainfrom
zerox80:main
Open

Fix duplicate folders and improve image caching performance#123
zerox80 wants to merge 2 commits intoopencloud-eu:mainfrom
zerox80:main

Conversation

@zerox80
Copy link
Copy Markdown
Contributor

@zerox80 zerox80 commented Apr 11, 2026

First up, this PR fixes a bug where the app sometimes displays folders twice in the UI, leaving one completely empty and one behaving normally.

The issue comes down to how different WebDAV proxies handle trailing slashes. When the app creates a folder locally, it applies a trailing slash to the path. But when the backend returns listings during syncs, it sometimes provides the path without that trailing slash. Because the database looks for a strict string match, the lookup fails and the app inserts a duplicate clone. To solve this, I tweaked the toModel mapper in OCRemoteFileDataSource.kt. It now forcibly appends the path separator to any incoming folder path if it is missing. This guarantees a safe match and prevents duplicate empty clones.

Second, I did some performance optimization on the thumbnail rendering. Generating preview URLs used to hit the Android AccountManager synchronously to fetch the base URL for every single loaded image. Making all those IPC calls on the main thread during a fast scroll was creating noticeable stutter. I added a ConcurrentHashMap to the ThumbnailsRequester to cache these base URLs in memory, keeping the RecyclerView lists scrolling incredibly smoothly.

@zerox80
Copy link
Copy Markdown
Contributor Author

zerox80 commented Apr 12, 2026

@guruz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant