Fix duplicate folders and improve image caching performance#123
Open
zerox80 wants to merge 2 commits intoopencloud-eu:mainfrom
Open
Fix duplicate folders and improve image caching performance#123zerox80 wants to merge 2 commits intoopencloud-eu:mainfrom
zerox80 wants to merge 2 commits intoopencloud-eu:mainfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First up, this PR fixes a bug where the app sometimes displays folders twice in the UI, leaving one completely empty and one behaving normally.
The issue comes down to how different WebDAV proxies handle trailing slashes. When the app creates a folder locally, it applies a trailing slash to the path. But when the backend returns listings during syncs, it sometimes provides the path without that trailing slash. Because the database looks for a strict string match, the lookup fails and the app inserts a duplicate clone. To solve this, I tweaked the toModel mapper in OCRemoteFileDataSource.kt. It now forcibly appends the path separator to any incoming folder path if it is missing. This guarantees a safe match and prevents duplicate empty clones.
Second, I did some performance optimization on the thumbnail rendering. Generating preview URLs used to hit the Android AccountManager synchronously to fetch the base URL for every single loaded image. Making all those IPC calls on the main thread during a fast scroll was creating noticeable stutter. I added a ConcurrentHashMap to the ThumbnailsRequester to cache these base URLs in memory, keeping the RecyclerView lists scrolling incredibly smoothly.