Skip to content

Make editor audio-only proof#1706

Open
Arnei wants to merge 2 commits into
opencast:developfrom
Arnei:audio-only
Open

Make editor audio-only proof#1706
Arnei wants to merge 2 commits into
opencast:developfrom
Arnei:audio-only

Conversation

@Arnei

@Arnei Arnei commented May 28, 2026

Copy link
Copy Markdown
Member

Fixes #1636.

Make sure the editor deals reasonably well with audio-only tracks.

Includes:

  • Displaying a little image for the player if there is no video stream.
  • Make sure the track selection makes sense (don't display a video stream for an audio only track, don't allow users to deselect all tracks)
  • Disable thumbnail generation for audio-only tracks, but keep thumbnail generation.

How to test this

The default community workflows attempt to circumvent the audio-only issue somewhat by adding dummy video track consisting of one image to the preview tracks for the editor. To generate true audio-only preview tracks for testing, you will want to change the relevant part in etc/workflows/partial-preview to something like this:

  # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
  # Track previews

  # Create track previews for video editor stream selection feature
  # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
  - id: image
    exception-handler-workflow: partial-error
    description: Create video preview images for presenter and presentation
    configurations:
      - source-flavor: '*/source'
      - target-flavor: '*/video+preview'
      - target-tags: preview
      - encoding-profile: editor.tracks.preview
      - time: 50%

  - id: prepare-av
    if: NOT (${presenter_source_video} OR ${presentation_source_video}) AND ${presenter_source_audio}
    description: Preparing presenter audio and video work versions
    configurations:
      - source-flavor: 'presenter/source'
      - target-flavor: 'presenter/preview'
      - rewrite: false
      - audio-muxing-source-flavors: '*/source'

  - id: prepare-av
    if: NOT (${presenter_source_video} OR ${presentation_source_video}) AND ${presentation_source_audio}
    description: Preparing presenter audio and video work versions
    configurations:
      - source-flavor: 'presentation/source'
      - target-flavor: 'presentation/preview'
      - rewrite: false
      - audio-muxing-source-flavors: '*/source'

  - id: tag
    description: Tagging media package elements
    configurations:
      - source-flavors: 'presenter/preview, presentation/preview'
      - target-tags: preview
      - copy: false

Make sure the editor still behaves reasonably for normal video files as well.

Screenshot:

Bildschirmfoto vom 2026-05-28 15-38-35

@Arnei Arnei added the type:enhancement New feature or request label May 28, 2026
Make sure the editor deals reasonably well with
audio-only tracks.
Includes:
- Displaying a little image for the player if there is
no video stream.
- Make sure the track selection makes sense (don't display
a video stream for an audio only track,
don't allow users to deselect all tracks)
- Disable thumbnail generation for audio-only tracks, but keep
thumbnail generation.
@github-actions

Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/1706/2026-05-28_14-01-43/ .
It might take a few minutes for it to become available.

@snoesberger snoesberger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the editor's ability to handle audio-only files!

My tests were successful, I just have a few minor points to mention:

  • In dark mode, the video-off.png image is barely visible: Image
    Ideally, the image would behave in the same way as the menu items.
  • Once this PR has been merged, the default Opencast workflow should be changed in the Opencast repository as you described.
  • It would probably be also a good idea to change the default values for the trackSelection of the editor config etc/ui-config/mh_default_org/editor/editor-settings.toml:
[trackSelection]

# If the track selection appears in the main menu
# Type: boolean
# Default: true
#show = true

# Ensure that at least one video stream remains selected
# Typically, the track selection ensures that at least one video stream
# remains selected. If you would like your users to be able to create selections
# with only audio streams, set this to false.
# Default: true
atLeastOneVideo = false

With the way we do it now, we can't change the color of the audio only
icon, as it is effictively an image. But we can change the background
for the icon instead.

Also fixes an issue where themed css was not properly applied
to the react player.
@Arnei

Arnei commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

I am not sure if setting atLeastOneVideo = false as the default setting is a good idea. At the very least, I remember other adopters not caring for audio only events and always wanting at least one video selected.

@snoesberger

Copy link
Copy Markdown
Contributor

I am not sure if setting atLeastOneVideo = false as the default setting is a good idea. At the very least, I remember other adopters not caring for audio only events and always wanting at least one video selected.

OK, then. Let's leave it as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support editing of audio-only files

2 participants