Conversation
…llArgumentsDoneEvent.name
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4304dbc8a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -76,29 +76,9 @@ def __stream__(self) -> Iterator[_T]: | |||
| ) | |||
|
|
|||
| yield process_data(data=data, cast_to=cast_to, response=response) | |||
There was a problem hiding this comment.
This now passes sse.json() straight into process_data, which drops sse.event for named SSE frames. That breaks endpoints still typed as discriminated assistant stream events (for example runs.create(..., stream=True) uses Stream[AssistantStreamEvent] in src/openai/resources/beta/threads/runs/runs.py, while AssistantStreamEvent requires top-level event and data in src/openai/types/beta/assistant_stream_event.py). In those streams, the discriminator comes from the SSE event name, so parsing will misclassify or fail once event is no longer reattached; the same issue also applies to the async path.
Useful? React with 👍 / 👎.
1 participant
Changes being requested
Additional context & links