Repository navigation
fix: preserve pending async calls in committed sessions - #6039
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
seratch
left a comment
There was a problem hiding this comment.
Thanks for narrowing this to committed session reads. One case still loses the pending call and its preceding reasoning. The pinned OpenAI client defines async on ResponseCustomToolCall, but its output and replay input types have no status field. The current test adds "status": "completed" to the custom call, and another test explicitly expects the statusless form to be pruned.
Please accept a committed custom_tool_call with async: true, a nonempty call_id, and no status. Update the session replay test to use a serialized ResponseCustomToolCall and assert that the next model request includes both the call and its preceding reasoning before the output arrives.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 244ebe8598
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.