Skip to content

fix(helm): add missing gateway env vars, deploy control, and sidecar support #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thepagent merged 3 commits into from
May 3, 2026
+370 −5
Merged

fix(helm): add missing gateway env vars, deploy control, and sidecar support #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9fa23d
fix(helm): add missing gateway env vars, deploy control, and sidecar …
JARVIS-coding-Agent May 2, 2026
9afa9ad
fix(helm): clean up deploy guard and remove single-arg and
JARVIS-coding-Agent May 2, 2026
ed1b8a2
style(helm): use with instead of if for extraVolumes consistency
May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions charts/openab/templates/gateway-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
{{- range $name, $cfg := .Values.agents }}
{{- if and (ne (include "openab.agentEnabled" $cfg) "false") ($cfg.gateway).enabled }}
{{- if and (ne (include "openab.agentEnabled" $cfg) "false") (($cfg.gateway).enabled) }}
{{- if ne (($cfg.gateway).deploy | toString) "false" }}
{{- $gwCfg := omit $cfg "nameOverride" }}
{{- $d := dict "ctx" $ "agent" (printf "%s-gateway" $name) "cfg" $gwCfg }}
{{- $hasTeams := and (($cfg.gateway).teams).appId (($cfg.gateway).teams).appSecret }}
{{- $hasFeishu := and (($cfg.gateway).feishu).appId (($cfg.gateway).feishu).appSecret }}
{{- if or $hasTeams $hasFeishu }}
{{- $hasTelegram := (($cfg.gateway).telegram).botToken }}
{{- $hasLine := (($cfg.gateway).line).channelSecret }}
{{- if or $hasTeams $hasFeishu $hasTelegram $hasLine }}
---
apiVersion: v1
kind: Secret
Expand All @@ -28,6 +31,19 @@ data:
feishu-encrypt-key: {{ ($cfg.gateway).feishu.encryptKey | b64enc | quote }}
{{- end }}
{{- end }}
{{- if $hasTelegram }}
telegram-bot-token: {{ (($cfg.gateway).telegram).botToken | b64enc | quote }}
{{- if (($cfg.gateway).telegram).secretToken }}
telegram-secret-token: {{ (($cfg.gateway).telegram).secretToken | b64enc | quote }}
{{- end }}
{{- end }}
{{- if $hasLine }}
line-channel-secret: {{ (($cfg.gateway).line).channelSecret | b64enc | quote }}
{{- if (($cfg.gateway).line).channelAccessToken }}
line-channel-access-token: {{ (($cfg.gateway).line).channelAccessToken | b64enc | quote }}
{{- end }}
{{- end }}
{{- end }}
{{- end }}
{{- end }}
{{- end }}
60 changes: 59 additions & 1 deletion charts/openab/templates/gateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
{{- range $name, $cfg := .Values.agents }}
{{- if and (ne (include "openab.agentEnabled" $cfg) "false") ($cfg.gateway).enabled }}
{{- if ne (($cfg.gateway).deploy | toString) "false" }}
{{- $gwCfg := omit $cfg "nameOverride" }}
{{- $d := dict "ctx" $ "agent" (printf "%s-gateway" $name) "cfg" $gwCfg }}
{{- $agentD := dict "ctx" $ "agent" $name "cfg" $cfg }}
{{- $hasTeams := and (($cfg.gateway).teams).appId (($cfg.gateway).teams).appSecret }}
{{- $hasTelegram := (($cfg.gateway).telegram).botToken }}
{{- $hasLine := (($cfg.gateway).line).channelSecret }}
---
apiVersion: apps/v1
kind: Deployment
Expand Down Expand Up @@ -43,13 +46,44 @@ spec:
protocol: TCP
env:
{{- if ($cfg.gateway).token }}
{{- $agentD := dict "ctx" $ "agent" $name "cfg" $cfg }}
- name: GATEWAY_WS_TOKEN
valueFrom:
secretKeyRef:
name: {{ include "openab.agentFullname" $agentD }}
key: gateway-ws-token
{{- end }}
{{- if $hasTelegram }}
- name: TELEGRAM_BOT_TOKEN
valueFrom:
secretKeyRef:
name: {{ include "openab.agentFullname" $d }}
key: telegram-bot-token
{{- if (($cfg.gateway).telegram).secretToken }}
- name: TELEGRAM_SECRET_TOKEN
valueFrom:
secretKeyRef:
name: {{ include "openab.agentFullname" $d }}
key: telegram-secret-token
{{- end }}
{{- if (($cfg.gateway).telegram).webhookPath }}
- name: TELEGRAM_WEBHOOK_PATH
value: {{ (($cfg.gateway).telegram).webhookPath | quote }}
{{- end }}
{{- end }}
{{- if $hasLine }}
- name: LINE_CHANNEL_SECRET
valueFrom:
secretKeyRef:
name: {{ include "openab.agentFullname" $d }}
key: line-channel-secret
{{- if (($cfg.gateway).line).channelAccessToken }}
- name: LINE_CHANNEL_ACCESS_TOKEN
valueFrom:
secretKeyRef:
name: {{ include "openab.agentFullname" $d }}
key: line-channel-access-token
{{- end }}
{{- end }}
{{- if $hasTeams }}
- name: TEAMS_APP_ID
value: {{ ($cfg.gateway).teams.appId | quote }}
Expand Down Expand Up @@ -141,6 +175,29 @@ spec:
resources:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with ($cfg.gateway).extraVolumeMounts }}
volumeMounts:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with ($cfg.gateway).extraContainers }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with ($cfg.gateway).nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with ($cfg.gateway).affinity }}
affinity:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with ($cfg.gateway).tolerations }}
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with ($cfg.gateway).extraVolumes }}
volumes:
{{- toYaml . | nindent 8 }}
{{- end }}
---
apiVersion: v1
kind: Service
Expand All @@ -159,3 +216,4 @@ spec:
{{- include "openab.selectorLabels" $d | nindent 4 }}
{{- end }}
{{- end }}
{{- end }}
Loading
Loading