fix(chart): apply hasKey to remaining boolean defaults for consistency#672
Closed
chaodu-agent wants to merge 1 commit intomainfrom
Closed
fix(chart): apply hasKey to remaining boolean defaults for consistency#672chaodu-agent wants to merge 1 commit intomainfrom
chaodu-agent wants to merge 1 commit intomainfrom
Conversation
removeAfterReply and usercronEnabled used '| default false' which happens to work today but creates a latent trap — if anyone changes the default to true in the future, the same false-is-zero-value bug from PR #639 would resurface. Apply the hasKey pattern to both fields for consistency with the enabled fields already fixed in #639.
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
Collaborator
Author
|
Closing — will fold this fix into PR #639 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
PR #639 fixed the
| default truetrap forenabledfields, but two| default falsefields were left unchanged:remove_after_reply = {{ ($cfg.reactions).removeAfterReply | default false }}usercron_enabled = {{ (($cfg.cron).usercronEnabled) | default false }}While
{{ false | default false }}happens to produce the correct result today, it creates a latent trap — if anyone changes the default totruein the future, the same false-is-zero-value bug would resurface silently.Flagged during triage review of PR #639.
Changes
charts/openab/templates/configmap.yamlTesting
Related