Repository navigation
fix(web-ui): keep todo editor form from collapsing on older WebKit - #3855
Merged
Merged
Conversation
The todo editor was a grid with `max-height: 100%` and a `minmax(0, 1fr)` middle row inside a dialog body without a definite height. Older WebKit (macOS 14 WKWebView) resolved that pair to a 0px form row, so the footer covered the clipped fields. Lay the editor out as a flex column instead: the intro and actions keep their size and only the scrollable form body shrinks. Fixes openBitFun#3718
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 创建待办 (create todo) dialog could show only its title and footer, with the footer drawn over a clipped strip of the form, as reported on macOS Sonoma 14.3.1 in #3718. It happened with and without an external monitor.
The todo editor is now a flex column instead of a grid with
max-height: 100%and aminmax(0, 1fr)form row. The intro and actions keep their natural size; only the scrollable form body shrinks.Fixes #3718
Type and Areas
Type: Bug fix
Areas: web UI (Todos scene editor dialog)
Motivation / Impact
The dialog surface has no definite height, only a
max-block-size. Inside its body the editor resolved a percentagemax-heightand anfrrow against that indefinite height. The desktop app renders with the system WKWebView, so layout follows the user's macOS version. Older WebKit resolves those sizes from the wrong height and gave the form row 0px, while newer WebKit lays the same CSS out correctly. That is why the dialog looks fine on recent macOS and breaks on Sonoma 14.3.The flex-column layout matches the shared Dialog body pattern (
flex: 1 1 auto; min-block-size: 0) and does not depend on percentage orfrresolution. No visual change where the old layout already worked.Verification
pnpm run check:web: stopped at a typography audit violation indesign-system/packages/ui/src/components/Dialog/Dialog.module.css:77, which is already onmainand not touched here. Type-check did not run as a result; this PR changes SCSS only.Not reproduced or rechecked in the macOS 14 WKWebView desktop app (an older WebKit build was not available locally). Layout-only change; no remote scenario behavior is affected.
Checklist