Skip to content

Promote summary-only Copilot findings to review threads - #483

Closed
trask wants to merge 3 commits into
mainfrom
trask-copilot-review-findings
Closed

trask wants to merge 3 commits into
mainfrom
trask-copilot-review-findings

Conversation

@trask

@trask trask commented Oct 17, 2026

Copy link
Copy Markdown
Member

Promote Copilot's summary-only "previously missed" findings into review threads posted by the dashboard app, so authors can discuss or reject them and resolve the conversation.

Copies preserve Copilot's wording, severity, and source link. Findings count against the clean-review gate before and after promotion; resolving a copy clears the finding without reposting it on the same commit.

Only findings from the latest Copilot overview of the current head are copied. When the reported line is unavailable in the diff, use a file-level review comment instead.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 401d241a-a0d9-48c1-9af8-4c528f1138bb
@trask
trask requested a balanced review from Copilot October 17, 2026 19:07
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Closed · refreshed 2026-10-18 23:41 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Bot identity handling can defeat deduplication, and Markdown parsing can truncate findings or fail PR evaluation.

2 open issues
What changed in this PR

Promotes summary-only Copilot findings into dashboard-managed review threads so authors can discuss and resolve them.

Changes:

  • Extracts current-head findings with attribution and deduplication markers.
  • Adds inline/file-level delivery and clean-review gate integration.
  • Documents the workflow and adds regression coverage.
File Description
pull-request-dashboard/​README.md Documents promotion and resolution behavior.
.github/​scripts/​pull-request-dashboard/​test_state.py Tests promotion-intent persistence.
.github/​scripts/​pull-request-dashboard/​test_github_cli.py Tests comment posting and retry controls.
.github/​scripts/​pull-request-dashboard/​test_delivery.py Tests delivery integration.
.github/​scripts/​pull-request-dashboard/​test_copilot_review_findings.py Covers extraction, promotion, and gating.
.github/​scripts/​pull-request-dashboard/​state.py Serializes promotion intent.
.github/​scripts/​pull-request-dashboard/​pull_request_evaluation.py Computes promotion intent and source links.
.github/​scripts/​pull-request-dashboard/​pull_request_activity.py Attributes promoted comments to Copilot.
.github/​scripts/​pull-request-dashboard/​github_cli.py Adds diff mapping and comment creation.
.github/​scripts/​pull-request-dashboard/​discussion_lifecycle.py Applies Copilot lifecycle rules to copies.
.github/​scripts/​pull-request-dashboard/​delivery.py Invokes finding delivery.
.github/​scripts/​pull-request-dashboard/​dashboard_status.py Recognizes promotion markers.
.github/​scripts/​pull-request-dashboard/​dashboard_contracts.py Adds promotion-intent field.
.github/​scripts/​pull-request-dashboard/​copilot_review.py Includes summary findings in gate status.
.github/​scripts/​pull-request-dashboard/​copilot_review_findings.py Parses and deduplicates summary findings.
.github/​scripts/​pull-request-dashboard/​copilot_review_delivery.py Posts eligible findings after fresh checks.

Review effort: Balanced

Comment thread .github/scripts/pull-request-dashboard/copilot_review_findings.py Outdated
Comment thread .github/scripts/pull-request-dashboard/dashboard_status.py
trask and others added 2 commits October 18, 2026 00:52
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved blocking issues remain, and regression coverage addresses parsing, trusted bot recognition, deduplication, delivery safeguards, and gate behavior.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

@trask trask closed this Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants