OpenAI v2: completion hook support and minor fixes#4315
Open
lmolkova wants to merge 11 commits intoopen-telemetry:mainfrom
Open
OpenAI v2: completion hook support and minor fixes#4315lmolkova wants to merge 11 commits intoopen-telemetry:mainfrom
lmolkova wants to merge 11 commits intoopen-telemetry:mainfrom
Conversation
Member
lmolkova
commented
Mar 7, 2026
lmolkova
commented
- Call completion hook in telemetry handler (if passed in constructor)
- Add should_record_content method to handler (so that instrumentations don't need to implement their own)
- Test against latest OpenAI and fix issues (new Omit type for values that were not provided)
lmolkova
changed the title
JWinermaSplunk
approved these changes
Mar 9, 2026
util/opentelemetry-util-genai/src/opentelemetry/util/genai/handler.py
Outdated
Show resolved
Hide resolved
util/opentelemetry-util-genai/src/opentelemetry/util/genai/handler.py
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-openai-v2/tests/test_completion_hook.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.