Skip to content

chore(nodejs): exclude test files from webpack ts compilation scope#2240

Merged
wpessers merged 1 commit intoopen-telemetry:mainfrom
wpessers:chore/nodejs/ts6-improvements
Apr 9, 2026
Merged

chore(nodejs): exclude test files from webpack ts compilation scope#2240
wpessers merged 1 commit intoopen-telemetry:mainfrom
wpessers:chore/nodejs/ts6-improvements

Conversation

@wpessers
Copy link
Copy Markdown
Member

@wpessers wpessers commented Apr 9, 2026

For the ts upgrade to v6 in #2222 I had to specify the mocha and sinon types in tsconfig since the test files were included in the compilation scope there. This tsconfig file however is specifically for compilation of the production code that gets bundled by webpack so it makes no sense to include the test files in the compilation scope there.

@wpessers wpessers requested a review from a team as a code owner April 9, 2026 19:55
@wpessers wpessers merged commit 3fd95aa into open-telemetry:main Apr 9, 2026
12 checks passed
@wpessers wpessers deleted the chore/nodejs/ts6-improvements branch April 9, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants