chore(nodejs): use native npm workspaces instead of lerna#2239
Merged
wpessers merged 1 commit intoopen-telemetry:mainfrom Apr 9, 2026
Merged
chore(nodejs): use native npm workspaces instead of lerna#2239wpessers merged 1 commit intoopen-telemetry:mainfrom
wpessers merged 1 commit intoopen-telemetry:mainfrom
Conversation
pragmaticivan
approved these changes
Apr 9, 2026
Member
pragmaticivan
left a comment
pragmaticivan
left a comment
There was a problem hiding this comment.
LGTM, but was not sure if we ever want workspaces without tests, but --if-present there makes sense to me. One could argue the same applies to all commands, but not a blocker.
Member
Author
|
Good point, I had to add the flag because the sample app workspace doesn't have any tests. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't use any lerna features, it's simply used as a script runner that uses the underlying npm workspaces. Therefore I just got rid of it entirely in favour of native npm workspace usage.