Avoid throwing for non-string process executable names - #4540
Open
ryux1 wants to merge 1 commit into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4540 +/- ##
==========================================
+ Coverage 83.47% 83.48% +0.01%
==========================================
Files 522 522
Lines 20440 20442 +2
==========================================
+ Hits 17061 17064 +3
+ Misses 3379 3378 -1
🚀 New features to boost your workflow:
|
ryux1
force-pushed
the
fix/resource-non-string-executable-name
branch
from
September 8, 2026 14:08
d86d10a to
e88afb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4535
Changes
process.executable.namewithnostd::get_ifwhen deriving the fallback service nameunknown_servicewhen the attribute exists with a non-string valueunknown_service:<process.executable.name>for valid string valuesValidation
bad_variant_accessfailure with the new regression test before applying the fixopentelemetry_resourcesbuilds with C++14 and-fno-exceptionsFor significant contributions:
CHANGELOG.mdupdated for non-trivial changesImplementation, tests, and this description were prepared with OpenAI Codex assistance.