[BUG] Check what curl_global_init returns (#4434) - #4531
Conversation
|
Thanks for this, and for asking on the issue first. Two things I checked that I think are right, and one question. The guard in Moving the The question. On One overlap to be aware of rather than to act on. #4406 makes the client survive without a multi handle from the other direction, where Small thing: "a private constructor to to simulate" in the header has a doubled "to". |
4f17cbf to
d2805e3
Compare
Ensure HttpCurlGlobalInitializer checks the return value of
curl_global_init. If initialization fails, log an error, avoid calling curl_global_cleanup, and cause HttpClient and HttpClientSync to report
SessionState::CreateFailed.
Fixes open-telemetry#4434
Signed-off-by: Varun <v08pandey@gmail.com>
d2805e3 to
2c5efd2
Compare
|
Thank you so much for the thorough review and insights :)
|
Fixes #4434.
initialization failure.