Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 5, 2026 06:34
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
removeMember(const String&)overload documents support for embedded nulls,but delegates through
c_str()to the null-terminated overload. This can removethe wrong property: if both
nameandname\0suffixexist, removing the latterdeletes
nameand leaves the requested property in place.Change
Delegate to the existing length-aware
removeMember(const String&, Value*)overload, retaining the one-argument overload's existing object/null type check.
No public API or ABI changes are needed.
Tests cover leading, internal and trailing NULs, preservation of prefix keys,
repeated removal of missing keys, null values, empty keys, and wrong-type
assertions. The regression produced 12 failed assertions before the fix.
Validation
JSON checker tests: pass; native unit cases increase from 131 to 133.
running the complete unit suite: pass.
patch whitespace checks: pass.
Validation was performed on Linux with GCC 14.2. The complete baseline was run
before implementation. Reader/writer runs were serialized because their test
artifacts share the source directory.
The local zizmor SARIF reporting command exits successfully and retains 34
pre-existing findings in the unchanged workflow definitions. Authenticated
online audits and SARIF upload were not run locally; this is not a claim of a
clean security audit.
AI tools assisted implementation and testing, with an independent AI-assisted
source review and native-suite rerun.