Repository navigation
fix(ontology): bound the concept binding lookup and declare property-chain members in the import IT - #36644
Conversation
OntologyConceptBindingCleanupIT asserts that every binding scan carries a
LIMIT, but OntologyConceptBindingDAO.find (a primary-key lookup) had none.
Add LIMIT 1; the key is (conceptId, assetId), so results are unchanged.
NativeOntologyImportListRulesIT built a property chain over two properties
the file never declared, which apply rejects ("Declare or import the
referenced property"). Declare both chain members in the CSV.
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ Approved🟡 Medium risk · Adding LIMIT 1 to the ontology binding lookup could conceal duplicate matching rows; the other change only adjusts integration-test data. Adds VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
🚦 Removed from the merge queue —
|
OntologyConceptBindingCleanupIT asserts that every binding scan carries a
LIMIT, but OntologyConceptBindingDAO.find (a primary-key lookup) had none.
Add LIMIT 1; the key is (conceptId, assetId), so results are unchanged.
NativeOntologyImportListRulesIT built a property chain over two properties
the file never declared, which apply rejects ("Declare or import the
referenced property"). Declare both chain members in the CSV.
Describe your changes:
Main has been red on three ontology ITs since #35991 and #35996 merged, in every lane, so every merge-queue build fails them and the queue cannot move.
OntologyConceptBindingCleanupIT(2 tests): the scan probe requires aLIMITon everyontology_concept_bindingread, butOntologyConceptBindingDAO.findhad none. It is a primary-key lookup on(conceptId, assetId), soLIMIT 1changes no result. Same pattern asfindPropertyEdgeAxiomPosition ... LIMIT 1.NativeOntologyImportListRulesIT.aFilePreviewAcceptsAlsoAppliesWhenItsListsAreUsable: the CSV built a property chain over two properties it never declared, which apply rejects (Declare or import the referenced property, a rule since Fixes 35671: Add native ontologies and governed releases #35672). The CSV now declares both chain members; the new-property count goes from 2 to 4.Both tests landed with these bugs; PR CI does not run ITs, so they first ran on main.
Tests:
OntologyConceptBindingCleanupIT2/2 andNativeOntologyImportListRulesIT4/4 pass (Tests run: 6, Failures: 0, Errors: 0), BUILD SUCCESS.Type of change: