Fixes 36392: Keep test result lines drawn in Safari and stop histogram bars overlapping by ShaileshParmar11 · Pull Request #36394 · open-metadata/OpenMetadata

ShaileshParmar11 · 2026-10-28T06:08:06Z

Describe your changes:

Summary

Two chart fixes from the Slack thread on the new Test Case Details page:

Safari loses the result-history line. Hovering a run, clicking one, or moving through runs with the keyboard made the line (and the wash under a single-series line) disappear in Safari. ECharts' own hover state animated every dot and line and moved the hovered series to the front; when the chart re-rendered in that state, zrender re-pointed its <g clip-path> groups at other <clipPath>s while rewriting them, and Safari kept drawing the line with an empty clip. The DOM stays correct, which is why it only shows in Safari.
Histogram bars overlap. The Recharts → ECharts move turned barSize={22} into a fixed barWidth: 22. Recharts shrank bars to fit their slot; ECharts does not, so a column with ~30 bins drew 22px bars in narrower slots.

 // TestSummaryGraph.tsx: every line and the aborted/queued dot series
 seriesOption: {
   connectNulls: true,
-  ...(isSingleSeries ? { areaStyle, lineStyle } : { emphasis: { focus: 'series' } }),
+  emphasis: { disabled: true },   // tooltip + selection ring are the hover feedback
+  ...(isSingleSeries && { areaStyle, lineStyle }),
 }

 // DataDistributionHistogram.component.tsx
-seriesOption: { barWidth: 22 },
+seriesOption: { barMaxWidth: 22 },

Hovering the chart no longer touches the SVG at all: 7 dots hovered went from ~1,000 SVG mutations (dot scale, line width, colour lift, series re-ordering) to 0. The app's tooltip still opens on hover and on keyboard navigation (verified in Chromium and Safari).

Evidence

Safari, single-series chart (Teddy's data), after hovering the runs and moving the pointer away:

Before (no fix)	After

Repeated real-Safari runs (WebDriver), each check samples 19 points along every drawn line and looks for the stroke colour in an element screenshot, across 3 charts (single series, min/max, mixed statuses incl. aborted/queued) × initial / hover / click / keyboard:

hover state on  (main)          18 / 36 checks lost a line   (keyboard: 9/9)
hover state off (this PR)        0 / 48 checks, then 0 / 24 on the final build

Histogram, 32 bins (left: barWidth, right: barMaxWidth):

Merge Danger

Door: two-way. Two series options; revert the commit to restore the old hover look.

Blast Radius: cosmetic. On the test case result chart, dots no longer grow and the other line no longer fades while hovering a min/max chart; tooltip, selection, click and keyboard behaviour are unchanged. Other charts keep their hover state (audited below).

Type of change:

Bug fix

High-level design:

N/A — small bug fix (2 components + tests + one impact-map line).

Tests:

Use cases covered

Safari: the result-history line stays drawn after hover, clicking runs, keyboard navigation, and on load, for single-series, min/max and mixed-status (aborted/queued) test cases.
The tooltip still opens on hover and keyboard navigation with the chart's hover state off.
The column profiler histogram's bars fit their slots when a column has many bins.

Unit tests

I added unit tests for the new/changed logic.
TestSummaryGraph.test.tsx: every line series and the aborted/queued dot series have no hover state (the dot test fails with the setting removed). Suite: 122/122 passed.
DataDistributionHistogram.test.tsx: series uses barMaxWidth: 22. 5/5 passed.
Coverage (jest --coverage): TestSummaryGraph.tsx 98.75% lines, DataDistributionHistogram.component.tsx 97.14% lines.

Backend integration tests

Not applicable (no backend API changes).

Ingestion integration tests

Not applicable (no ingestion changes).

Playwright (UI) tests

Not applicable for new specs: the change is a series option; the visual Safari behaviour can't be asserted in the Chromium CI project. Added the histogram to the Data Quality/Profiler mapping in .github/playwright/impact-map.json (it had no mapping, so CI would have run the full suite).
Ran locally against this branch's UI (PLAYWRIGHT_TEST_BASE_URL=http://localhost:3000, --project=chromium): Features/DataQuality/TestCaseDetailsPage.spec.ts + Features/DataQuality/Profiler.spec.ts with their setup dependencies — 24 tests, all passed. The other ~65 impact-mapped specs were not run locally; the merge queue runs them.

Manual testing performed

Local stack (docker/development, MySQL + Elasticsearch, sample data) with this branch's UI on yarn start (:3000); Safari 26 driven by safaridriver and checked by eye.
Seeded a dynamic tableRowCountToBeBetween test case with Teddy's 7 results, a dynamic columnValuesToBeBetween (min/max) case, and a mixed Success/Failed/Aborted/Queued case.
On each Results tab: hovered every run, clicked runs, focused the chart and used ←/→/Enter, reloaded — the lines stayed drawn; on main they vanished.
Seeded 7 days of table/column/system profiles (32-bin histogram, cardinality, custom metrics) and audited all 72 test case, profiler, data quality and incident charts in classic and AI mode in Safari vs Chromium: same rendering, and every chart returns to its resting state after hover.
Column profile → Data distribution: bars no longer overlap.

UI screen recording:

Not applicable — bug fix, not a feature. Before/after Safari screenshots are under Evidence.

Checklist:

Confidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

This PR disables ECharts hover styling on test-result lines and status dots, and lets histogram bars shrink below 22 pixels.

Test result lines stay visible while people explore runs.
Histogram bars fit their bins when there are many of them.

_{Reviews (2) · Last reviewed commit: "Merge branch 'main' into ShaileshParmar1..." · Reviewed by Greptile}

…rs overlapping The test case result chart lost its line (and the area wash) in Safari after hovering a run, clicking one, or moving through runs with the keyboard. On hover ECharts animated every dot and line and moved the hovered series to the front; when the chart re-rendered in that state, zrender re-pointed its clipped groups at other clip paths and Safari kept drawing them with an empty clip. The chart's own hover state is now off: the tooltip and the selection ring already give the hover feedback, so a pass of the pointer no longer touches the SVG at all. The column data distribution histogram set a fixed 22px bar width, carried over from Recharts' barSize. Recharts shrank bars to fit their slot; ECharts does not, so a histogram with many bins drew bars wider than their slots and they overlapped. It is now a 22px cap.

…ogram to profiler specs The no-hover setting on the dots of aborted and queued runs had no test. The histogram had no Playwright impact mapping, so CI would have run the full suite for it; it now maps to the Data Quality and profiler specs that render it.

Copilot

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

github-actions · 2026-10-28T06:08:17Z

✅ PR checks passed

The linked issue has a description and all required Shipping project fields set. Thanks!

github-actions · 2026-10-28T06:08:46Z

🔄 Playwright impact map auto-refreshed

This PR touched specs or UI source that changed the source→spec routing map. I regenerated .github/playwright/impact-map.generated.json and pushed the diff to this branch.

- source entries: 994 → 996
- 2 added, 0 removed, 0 changed spec-list

New source→spec entries:
  openmetadata-ui/src/main/resources/ui/src/components/discovery/personal-space/Profile/tabs/applications/AppScheduleEdit.tsx
  openmetadata-ui/src/main/resources/ui/src/components/discovery/personal-space/Profile/tabs/platform-settings/search/FieldValueBoostFields.tsx

What is this file? It is the auto-generated half of Playwright's PR planner. It routes "if source X changes, run specs Y" by walking spec imports and cross-referencing getByTestId strings. Hand-authored routing in impact-map.json always wins on conflict.

What if I want to regenerate locally instead? Run this before pushing your next change to skip the bot commit:

python3 .github/scripts/generate_playwright_impact_map.py
git add .github/playwright/impact-map.generated.json
git commit --amend --no-edit  # or a separate commit

Copilot

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

github-actions · 2026-10-28T06:29:13Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	79.77% (131391/164697)	66.28% (46329/69898)	69.24% (26305/37989)

Copilot

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

gitar-bot · 2026-10-28T07:10:51Z

Code Review ✅ Approved

🟡 Medium risk · Disabling chart hover emphasis removes dot and line highlighting, which could make result series harder to distinguish; histogram bars now shrink to fit bins.

Keeps test result lines drawn in Safari by disabling ECharts hover emphasis on line and dot series, and switches the histogram from barWidth to barMaxWidth so bars shrink to fit their slots. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source}

sonarqubecloud · 2026-10-28T07:26:59Z

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

…m bars overlapping (#36394) (#36449) * fix(ui): keep test result lines drawn in Safari and stop histogram bars overlapping The test case result chart lost its line (and the area wash) in Safari after hovering a run, clicking one, or moving through runs with the keyboard. On hover ECharts animated every dot and line and moved the hovered series to the front; when the chart re-rendered in that state, zrender re-pointed its clipped groups at other clip paths and Safari kept drawing them with an empty clip. The chart's own hover state is now off: the tooltip and the selection ring already give the hover feedback, so a pass of the pointer no longer touches the SVG at all. The column data distribution histogram set a fixed 22px bar width, carried over from Recharts' barSize. Recharts shrank bars to fit their slot; ECharts does not, so a histogram with many bins drew bars wider than their slots and they overlapped. It is now a 22px cap. * test(ui): cover the aborted/queued dots' hover state and map the histogram to profiler specs The no-hover setting on the dots of aborted and queued runs had no test. The histogram had no Playwright impact mapping, so CI would have run the full suite for it; it now maps to the Data Quality and profiler specs that render it. * chore(playwright): auto-refresh impact-map.generated.json --------- (cherry picked from commit 83026f9) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

ShaileshParmar11 added 2 commits October 28, 2026 11:29

Copilot AI balanced review requested due to automatic review settings October 28, 2026 06:08

ShaileshParmar11 requested a review from a team as a code owner October 28, 2026 06:08

ShaileshParmar11 requested a review from karthicksharan October 28, 2026 06:08

Copilot AI reviewed Oct 28, 2026

ShaileshParmar11 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Oct 28, 2026

chore(playwright): auto-refresh impact-map.generated.json

13c3926

Copilot AI balanced review requested due to automatic review settings October 28, 2026 06:08

Copilot AI reviewed Oct 28, 2026

Rohit0301 approved these changes Oct 28, 2026

View reviewed changes

Merge branch 'main' into ShaileshParmar11/collate-conversation-check

7d22e41

Copilot AI balanced review requested due to automatic review settings October 28, 2026 07:09

Copilot AI reviewed Oct 28, 2026

ShaileshParmar11 added this pull request to the merge queue Oct 28, 2026

Merged via the queue into main with commit 83026f9 Oct 28, 2026
84 checks passed

ShaileshParmar11 deleted the ShaileshParmar11/collate-conversation-check branch October 28, 2026 11:31

ShaileshParmar11 mentioned this pull request Oct 28, 2026

[2.1] Fixes #36392: Keep test result lines drawn in Safari and stop histogram bars overlapping #36449

Merged

4 tasks done

Navigation Menu

Repository navigation

Fixes 36392: Keep test result lines drawn in Safari and stop histogram bars overlapping - #36394

Fixes 36392: Keep test result lines drawn in Safari and stop histogram bars overlapping#36394
ShaileshParmar11 merged 4 commits into
mainfrom
ShaileshParmar11/collate-conversation-check

ShaileshParmar11 commented Oct 28, 2026 •

edited by greptile-apps Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

gitar-bot Bot commented Oct 28, 2026

Uh oh!

sonarqubecloud Bot commented Oct 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ShaileshParmar11 commented Oct 28, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Summary

Evidence

Merge Danger

Type of change:

High-level design:

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording:

Checklist:

Confidence Score: 5/5

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ PR checks passed

Uh oh!

github-actions Bot commented Oct 28, 2026

🔄 Playwright impact map auto-refreshed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jest test Coverage

UI tests summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

gitar-bot Bot commented Oct 28, 2026

Uh oh!

sonarqubecloud Bot commented Oct 28, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ShaileshParmar11 commented Oct 28, 2026 •

edited by greptile-apps Bot

Loading

github-actions Bot commented Oct 28, 2026 •

edited

Loading

github-actions Bot commented Oct 28, 2026 •

edited

Loading