[zerafachris]

Why

bool("false") returns True in Python — any non-empty string is truthy. tableColumnToMatchSet._run_validation was reading the ordered parameter with get_test_case_param_value(..., bool, default=False), so passing ordered: "false", "False" or "0" all silently enabled ordered matching. The only way to get unordered comparison was to omit the parameter entirely.

What changed

Switched from get_test_case_param_value(..., bool) to the existing get_bool_test_case_param helper (in validations/utils.py) which does str.lower() == "true", so every falsy string variant correctly yields False.

No other files changed.

Tests

Added test_case_column_to_match_set_ordered_false fixture and parametrized test cases in both the SQLite (database) and DataFrame (datalake) test paths:

ordered value	before (bug)	after (fix)
"false"	True (ordered)	False (unordered) ✓
"False"	True	False ✓
"true"	True	True ✓
omitted	False	False ✓

The new ordered_false test lists all 11 table columns in shuffled order (different from DDL order) and expects Success, which would have been Failed with the old code because ordered comparison would have seen a mismatched sequence.

Fixes #35616

Prepared with AI assistance (Claude Code, Anthropic), reviewed for correctness before submission.

🤖 Generated with Claude Code

Confidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Fixes tableColumnToMatchSet so ordered="false" uses unordered matching.

• Table-column checks treat ordered: "false" as unordered matching.

No new actionable issues found. Tests were not run.

_{Reviews (3) · Last reviewed commit: "test(data-quality): use ORM column keys ..." · Reviewed by Greptile}

---

Summary by Gitar

• Ingestion patch:
  • Converted patch.patch to a list in build_patch before array fields are appended in patch_request.py

_{This will update automatically on new commits.}

[github-actions]

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

• Linked issue tableColumnToMatchSet: ordered: "false" is treated as True, so unordered matching only works when the parameter is left out #35616 is not added to the Shipping project.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[zerafachris]

Pushed fed33d8 to fix the test_case_column_to_match_set_ordered_false failure in the Python unit tests (3.10/3.11/3.12).

The SQLAlchemy tableColumnToMatchSet validator reads the ORM column keys (inspect(table).c.keys()), so on the sqlite users table the first name column comes back as first_name. The datalake validator reads the DataFrame column, which is first name. The fixture both tests shared listed first name, so the database variant could never match. The CI run on the original commit was cancelled, so this only surfaced after the merge from main.

The database test now uses its own fixture, test_case_column_to_match_set_ordered_false_sqa, which lists first_name. The datalake test is unchanged. Locally, test_validations_databases.py and test_validations_datalake.py pass (135 passed). With ordered read the old way, get_test_case_param_value(..., bool), both ordered_false cases fail. ruff 0.15.12 is clean.

(Prepared with AI assistance (Claude Code, Anthropic), reviewed for correctness before submission.)

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[gitar-bot]

Code Review ✅ Approved

🟡 Medium risk · Correcting unordered column checks and normalizing patch operations affect validation results and entity updates, which could change detected quality failures or persisted metadata.

Switches the ordered parameter in tableColumnToMatchSet from bool casting to get_bool_test_case_param, so "false" and "False" correctly yield unordered matching. Also normalizes JSON patch operations in build_patch before array fields are appended. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source}

[sonarqubecloud]

Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud