Conversation
Signed-off-by: gruebel <anton.gruebel@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's development workflow by replacing the 'pre-commit' hook management system with 'prek'. This migration aims to improve performance and efficiency by utilizing 'uv' for Python hook setup and enabling parallel execution of hooks. The change also includes general updates to development dependency versions and streamlines the overall dependency lock file. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 98.33% 98.33% -0.01%
==========================================
Files 45 45
Lines 2164 2157 -7
==========================================
- Hits 2128 2121 -7
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request migrates the project from pre-commit to prek, which is a great improvement for performance. The changes are mostly correct, but I've found a few critical issues. The revisions for some hooks in .pre-commit-config.yaml do not exist, which will cause prek to fail. Additionally, the pre-commit poe task in pyproject.toml needs to be updated to use the prek command instead of pre-commit.
Signed-off-by: gruebel <anton.gruebel@gmail.com>
|
Do we need support for updating hooks with Renovate or is it ok to rely on the existing |
@federicobond as far as I know not needed, because it is the same file and the |
This PR
preklikecpython,airflowandruffuvinstead ofvirtualenvto setup Python hooks, which fits nicely in our setupprioritygroups