Skip to content

chore: update go to 1.26#883

Merged
frewilhelm merged 5 commits intoopen-component-model:mainfrom
frewilhelm:update-golang
Apr 7, 2026
Merged

chore: update go to 1.26#883
frewilhelm merged 5 commits intoopen-component-model:mainfrom
frewilhelm:update-golang

Conversation

@frewilhelm
Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Update to go 1.26 as dependencies require a new go version

Which issue(s) this PR is related to

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm requested a review from a team as a code owner April 7, 2026 06:33
@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Apr 7, 2026

If you do this, you also have to update the linter version and the controller runtime version the Tiltfile and the Dockerfile. :)

GOLANGCI_LINT_VERSION ?= v2.5.0 needs to be at least 2.11.3

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Apr 7, 2026

And while you are at it, setup-env version also needs to be pinned because it's installing latest that fails as well. ( like the previous run did )

sigs.k8s.io/controller-runtime/tools/setup-envtest@latest is not a good choice. :D

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
Copy link
Copy Markdown
Contributor Author

And while you are at it, setup-env version also needs to be pinned because it's installing latest that fails as well. ( like the previous run did )

sigs.k8s.io/controller-runtime/tools/setup-envtest@latest is not a good choice. :D

setup-envtest only has pseudo-releases :/ I think latest might be fine. WDYT?

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Apr 7, 2026

@frewilhelm Setup-envtest has release branches and lives with the controller runtime. That's why I said, you need to update that as well. :)

Please update it to use release-23 like this sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.23 and then update controller runtime to 0.23.3.

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Apr 7, 2026

Now I see I only said controller version and left out the runtime part. :D Sorry about that.

Makefile Outdated
@@ -150,7 +150,7 @@ KUSTOMIZE_VERSION ?= v3.8.7
CONTROLLER_TOOLS_VERSION ?= v0.19.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be 0.23.3 here. :)

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Apr 7, 2026

sigs.k8s.io/controller-tools/cmd/controller-gen@v0.23.3 nope.... it's release-23. v0.23.3 is for the controller-runtime.

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Apr 7, 2026

And then once you update the controller runtime don't forget to run make manifests && make generate

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
Copy link
Copy Markdown
Contributor Author

0.20.1 was working for me as its also the release

@frewilhelm
Copy link
Copy Markdown
Contributor Author

go: sigs.k8s.io/controller-runtime/tools/setup-envtest@release-23: sigs.k8s.io/controller-runtime/tools/setup-envtest@release-23: invalid version: unknown revision release-23

I don't think this will work^^

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Apr 7, 2026

WHAT THE ACTUAL FUCK. The release branches have been deleted on the repo. :O :O :O

I literally checked 20-30 minutes ago the release branches were there until release-23. :O

@frewilhelm
Copy link
Copy Markdown
Contributor Author

It should work with 75f0860

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Apr 7, 2026

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Apr 7, 2026

Frederic pointed out that that's the wrong repo adn the version was also miss written hahahaha

it should be

go install sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.23

@frewilhelm frewilhelm enabled auto-merge (squash) April 7, 2026 08:44
@frewilhelm frewilhelm merged commit 5e89c1d into open-component-model:main Apr 7, 2026
9 checks passed
@frewilhelm frewilhelm deleted the update-golang branch April 13, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants