Repository navigation
Use model key presence when resolving get defaults - #777
Open
shayanxcyber wants to merge 1 commit into
Open
shayanxcyber wants to merge 1 commit into
shayanxcyber wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
Message(role='user'),message['content']raisesKeyError, butmessage.get('content', '')returnsNone. A non-field name such asmodel_dumpalso returns the model's method rather than the fallback.Use the same key-presence check as indexing. Explicit
Noneand empty strings still retain their values, and model defaults such asTool.typeremain available.This also makes the fallback used by the chat and generate logprobs examples work when the response omits
logprobs.The mapping tests and type doctests pass (10 tests), as do Ruff checks and formatting. A broader serialization run had 28 passes and two temporary-file failures on Windows; both failing tests also fail at the base revision.