chore(ci): remove vestigial pnpm setup from dependabot-auto-merge.yml - #6423
Merged
Conversation
Once #6389 removed the lockfile merge driver, `corepack enable` + `pnpm --version` were the only pnpm steps left in a job whose own comment already says it never runs `pnpm install`. Removed both, with the reasoning (including why `pnpm --version` alone isn't kept as a fail-fast) recorded in the workflow file so the next reader does not re-add it unexplained. Reworded the `cache: 'pnpm'` comment on the Setup Node.js step to reflect that this job no longer sets up pnpm at all. Fixes #6392 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012CZgmFFzqA9cX8tBMhvpFe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6392
Premise, re-verified on
mainat this branch's own HEAD (9602dc820)Both halves confirmed before touching anything:
What changed
Removed both pnpm steps (
corepack enable,pnpm --version) fromdependabot-auto-merge.yml.actions/setup-nodestays — the merge-gate scriptis a
nodestep and needs the runtime regardless.Decision: cut both, don't keep
pnpm --versionas a fail-fast. Thereasoning is written into the workflow file itself (right where the two steps
used to be), summarized here:
pnpmtoday — its own next step already says itnever runs
pnpm install.this job actually depends on pnpm, and nothing does. Keeping it is an
unexplained two-line "just in case" setup with no consumer — which is the
exact shape of residue this issue is about; keeping half of the removal
recreates the same shape it names.
corepack enablesetup should go back in next to that step, where a reader can see what
it's for, not sitting two steps away from its only would-be consumer.
The
cache: 'pnpm'commentRe-read, not reflex-deleted, per the card's warning. Its underlying claim
("this job never runs
pnpm install, so a pnpm store cache would breaksetup-node's post-job save") is still true and still the right warning forthe next person who reaches for
cache: 'pnpm'on this job — reworded only tonote that the job doesn't set up pnpm at all any more, which makes the warning
even more clearly applicable, not less.
Scope
Only
dependabot-auto-merge.yml's two pnpm lines. Per PM dispatch, #6391 (samemechanism family) is explicitly out of scope for this PR —
changeset- release.yml, the.gitattributesline, and the "Lockfile Merge Driver"table's remaining row are untouched.
Tests
pnpm exec vitest run scripts/__tests__/(whole tree, as required becauseci-cd-pipeline-doc.test.tspinscontent/docs/guide/ci-cd-pipeline.mdagainst
.github/workflows/in both directions): 81 test files passed,2317 tests passed, run at commit
121ae518e(this branch's head).node scripts/check-changeset-presence.mjs: confirms no published-packagesource changed and the changeset already added is sufficient — "No source of
a released package changed in this range, so no changeset is owed."
python3 -c "import yaml; yaml.safe_load(...)"and listed the job's step names to confirm the two pnpm steps are gone and
every other step (including
actions/setup-node) is untouched.grep -rn "Enable Corepack\|Verify pnpm version" .github/workflows/—confirms
dependabot-auto-merge.ymlno longer appears in that list whileevery workflow that genuinely runs
pnpm install(ci.yml,lint.yml,changeset-release.yml, etc.) is untouched.Changeset
.changeset/6392-vestigial-pnpm-steps.md, empty frontmatter (CI-only change,no published package touched — objectui declares "no release" this way; the
skip-changesetlabel mechanism doesn't exist in this repo).Generated by Claude Code