Skip to content

fix(skills): state the ADR-0053 upper-bound rule in filters.md by reference #17943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Sep 13, 2026
+3 −3
Merged

fix(skills): state the ADR-0053 upper-bound rule in filters.md by reference #17943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions skills/objectstack-query/rules/filters.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,6 @@ untouched — `'user-{current_user_id}'` is a literal. Check a spelling with
`isDateMacroToken(tok)` / `isContextToken(tok)` from `@objectstack/spec/data`,
WITHOUT braces.

**`*_end` is a calendar DAY.** `{current_year_end}` is `2026-12-31`, so on a
`datetime` column `<= {current_year_end}` stops at midnight on the 31st. Use
the half-open `< {next_year_start}` for timestamps.
**`*_end` is a calendar DAY; an upper bound means the WHOLE day.**
`<= {current_year_end}` already reaches the final instant of Dec 31
(`calendar-day.ts`, ADR-0053 D-D): ⛔ Do NOT hand-write `< {next_year_start}`.
Loading