Skip to content

fix(docs): compare hostname, not authority, in legacy-host redirect #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 1 commit into from
Aug 26, 2026
+11 −1
Merged

fix(docs): compare hostname, not authority, in legacy-host redirect #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion apps/docs/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,18 @@ function getPreferredLanguage(request: NextRequest): string {
*/
export default function middleware(request: NextRequest) {
// Canonical domain redirect: legacy docs host -> canonical host (permanent).
//
// The Host header carries the authority, `host[:port]` (RFC 9110 §7.2), not
// just the hostname. Comparing it whole tested only the bare-host shape:
// `www.objectos.app:8080` is not `=== LEGACY_HOST`, so a ported request fell
// through to locale negotiation and got served (200) under the legacy host
// instead of redirected (308) off it — while three lines below, the target
// side already strips its port (`target.port = ''`). The port was accounted
// for on the way out and not on the way in (#226); comparing the hostname on
// both sides closes that gap without changing the target normalisation.
const host = request.headers.get('host');
if (host === LEGACY_HOST) {
const hostname = host?.split(':')[0];
if (hostname === LEGACY_HOST) {
const target = new URL(request.url);
target.protocol = 'https:';
target.host = SITE_HOST;
Expand Down