Skip to content

test(completion): react to Nightly changing highlight without hl_eol - #2530

Merged
echasnovski merged 1 commit into
nvim-mini:backlogfrom
abeldekat:test_fix_completion
Aug 14, 2026
Merged

test(completion): react to Nightly changing highlight without hl_eol#2530
echasnovski merged 1 commit into
nvim-mini:backlogfrom
abeldekat:test_fix_completion

Conversation

@abeldekat

Copy link
Copy Markdown
Member

Details:

  • See PR 41160 in neovim/neovim

@echasnovski

Copy link
Copy Markdown
Member

It doesn't look like this test in particular requires testing highlighting. So I think I'd prefer to only add { ignore_attr = true } to the failing screenshot test.

@abeldekat
abeldekat force-pushed the test_fix_completion branch from bf073a1 to e7a7c10 Compare August 8, 2026 12:08
@abeldekat

Copy link
Copy Markdown
Member Author

Done

@echasnovski

Copy link
Copy Markdown
Member

Thanks, I'll wait a bit before merging this since there are unrelated failing tests (due to upstream problems, it seems).

@echasnovski
echasnovski changed the base branch from main to backlog August 14, 2026 12:56
@echasnovski
echasnovski merged commit f66a0ef into nvim-mini:backlog Aug 14, 2026
10 of 12 checks passed
@echasnovski

Copy link
Copy Markdown
Member

Resolving neovim/neovim#41238 takes a bit more time than usual (although there is already a working PR, just not merged). So let's merge this and endure the red cross near the commits for a bit.

@abeldekat

Copy link
Copy Markdown
Member Author

Thanks!

@abeldekat
abeldekat deleted the test_fix_completion branch August 14, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants