Conversation
…eadlock Signed-off-by: Keran Yang <keran.yang@kaseya.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage ? 61.17%
Complexity ? 598
=======================================
Files ? 157
Lines ? 3668
Branches ? 271
=======================================
Hits ? 2244
Misses ? 1247
Partials ? 177 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Comment on lines
113
to
115
Contributor
There was a problem hiding this comment.
Although async, should we add the fix here as well?
Member
Author
There was a problem hiding this comment.
Good catch Vaibhav, thanks! Since we fixed the shutdown hook to stop the AKKA system, this line is actually fixed because System.exit(0); triggers the shutdown hook. I updated the comments.
vaibhavtiwari33
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to prevent shutdown deadlock, for both source transformer and mapper. Also added a unit test to reproduce the issue and verify the fix.