Skip to content

fix: remove System.exit from JVM shutdown hooks - #225

Merged
KeranYang merged 2 commits into
mainfrom
tfb
Aug 17, 2026
Merged

fix: remove System.exit from JVM shutdown hooks#225
KeranYang merged 2 commits into
mainfrom
tfb

Conversation

@KeranYang

Copy link
Copy Markdown
Member

to prevent shutdown deadlock, for both source transformer and mapper. Also added a unit test to reproduce the issue and verify the fix.

…eadlock

Signed-off-by: Keran Yang <keran.yang@kaseya.com>
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@be343da). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../main/java/io/numaproj/numaflow/mapper/Server.java 0.00% 13 Missing ⚠️
...io/numaproj/numaflow/sourcetransformer/Server.java 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage        ?   61.17%           
  Complexity      ?      598           
=======================================
  Files           ?      157           
  Lines           ?     3668           
  Branches        ?      271           
=======================================
  Hits            ?     2244           
  Misses          ?     1247           
  Partials        ?      177           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 113 to 115

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although async, should we add the fix here as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Vaibhav, thanks! Since we fixed the shutdown hook to stop the AKKA system, this line is actually fixed because System.exit(0); triggers the shutdown hook. I updated the comments.

Signed-off-by: Keran Yang <keran.yang@kaseya.com>
@KeranYang
KeranYang merged commit 17ce3fa into main Aug 17, 2026
5 checks passed
@KeranYang
KeranYang deleted the tfb branch August 17, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants