Repository navigation
fix(deps): electron 44.11.3 and patched advisory packages (same major) - #662
Merged
Merged
Conversation
Narrow bump, no npm audit fix. Old -> new: - electron 44.5.1 -> 44.11.3 (exact pin kept) - @modelcontextprotocol/sdk 1.30.0 -> 1.32.2 - dompurify 3.4.16 -> 3.4.17 - zod 4.5.4 -> 4.6.7 - proxy-addr 2.0.7 -> 2.0.8 - body-parser 2.3.0 -> 2.4.0 (content-type 2.0.0 -> 2.1.0, iconv-lite 0.7.2 -> 0.7.3 nested) - undici 7.30.0 -> 7.30.2; node-gyp undici 6.29.0 -> 6.29.1 - source-map-js 1.2.1 -> 1.2.2 - vite 7.3.5 -> 7.3.8 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The new 4 MiB transport limit can reject supported inline canvas_render inputs with HTTP 413 due to JSON escaping, requiring limit alignment and an HTTP boundary regression test.
No open issues 🎉
What changed in this PR
Updates AI Code Conductor’s Electron runtime and selected dependencies to address reported advisories without major-version upgrades.
Changes:
- Pins Electron to
44.11.3in the manifest and lockfile. - Updates MCP SDK, DOMPurify, Zod, and selected transitive and tooling packages while leaving the electron-builder family unchanged.
| File | Description |
|---|---|
package.json |
Updates the exact Electron version pin. |
package-lock.json |
Locks the patched dependency versions and associated metadata. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The pre-release alert check for 2.1.3-beta.1 ran
npm auditon the candidate lockfile. It reported 2 critical and 7 high advisories, all older than this beta and all fixable within the same major. Dependabot shows the same packages, but it only scansmain.A read-only reachability check against the shipped app found one reachable:
Not reachable in the shipped app; bumped anyway because the fix is a patch or minor:
What changed
Only these lockfile entries moved (no
npm audit fix; the electron-builder family, vitest, mermaid and hono are untouched):After:
npm auditshows 0 critical and 0 high (18 moderate, 4 low; those need major changes in the build-time electron-builder tree or the excalidraw tree, and go to a ticket).Review and risk
canvas_renderpayload could now hit that limit.Merge only after the owner approves adding it to 2.1.3-beta.1. If approved, it merges before the model-definitions PR, which carries the version bump.
🤖 Generated with Claude Code