fix(workflow): support dependabot pr titles#451
Conversation
| assert.match(PR_TITLE, SCOPE_RGX, INVALID_PR_TITLE_ERR); | ||
| const firstParen = PR_TITLE.indexOf('('); | ||
| const prefix = PR_TITLE.slice(0, firstParen); | ||
| const [_, prefix] = SCOPE_RGX.exec(PR_TITLE) || []; |
There was a problem hiding this comment.
I added an alternative in the regex and captured the prefix for both scenarios. I think this is simpler than implementing a separate approach here, especially since this PR introduces dep: bump as a valid case as well, which doesn’t have parentheses.
But if this isn't good for some reason, let me know
|
I think it would be better to update Dependabot's config to include scope (and then the PR title will pass). |
Oh yeah, I agree—that sounds better. What should the prefix be? dep(workspace)? Or is there a clearer name for the scope? |
Edit: Wait, do you mean There are 2 dependapot categories defined in its config (the other is for npm). In the npm case, if possible something like |
What do dev and prod actually represent in our case? |
An npm development dependency (eg |
Got it, done. Let me know if I missed anything or if there’s any room for improvement. Thanks for your patience 😁 |
JakobJingleheimer
left a comment
There was a problem hiding this comment.
🙌 ha, no patience needed. Thanks for handling!
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
The PRs created by Dependabot do not have valid titles for our CI, so I updated the regex to support dep: bump ... as well.