Skip to content

feat(axios-to-whatwg-fetch): introduce #269

Merged
AugustinMauroy merged 47 commits intomainfrom
feat/axios-to-whatwg-fetch
Apr 30, 2026
Merged

feat(axios-to-whatwg-fetch): introduce #269
AugustinMauroy merged 47 commits intomainfrom
feat/axios-to-whatwg-fetch

Conversation

@AugustinMauroy
Copy link
Copy Markdown
Member

@AugustinMauroy AugustinMauroy commented Nov 8, 2025 •
edited
Loading

@AugustinMauroy AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Nov 8, 2025
@AugustinMauroy AugustinMauroy requested review from a team and removed request for a team November 8, 2025 13:49
@AugustinMauroy AugustinMauroy removed the awaiting reviewer Author has responded and needs action from the reviewer label Nov 8, 2025
@AugustinMauroy AugustinMauroy marked this pull request as draft November 8, 2025 13:50
@JakobJingleheimer
Copy link
Copy Markdown
Member

JakobJingleheimer commented Nov 9, 2025

omg please yes

@AugustinMauroy AugustinMauroy requested a review from a team December 10, 2025 10:34
@AugustinMauroy
Copy link
Copy Markdown
Member Author

AugustinMauroy commented Dec 13, 2025

cc @nodejs/userland-migrations can I have first review on this one

@AugustinMauroy AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Dec 13, 2025
@JakobJingleheimer
Copy link
Copy Markdown
Member

JakobJingleheimer commented Jan 17, 2026

It looks like CI did run?

If not, was this whilst I was fiddling with the repo permissions? (I specifically told you on slack you'd temporarily have read-only permissions for a bit, which means you couldn't do anything other than read within the repo)

@AugustinMauroy
Copy link
Copy Markdown
Member Author

AugustinMauroy commented Jan 17, 2026

It looks like CI did run?

If not, was this whilst I was fiddling with the repo permissions? (I specifically told you on slack you'd temporarily have read-only permissions for a bit, which means you couldn't do anything other than read within the repo)

it's ran after the merge commit. idk what really happened but it's work now !

it's didn't help since I dunno why windows is doing windows thing

@AugustinMauroy AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Jan 17, 2026
JakobJingleheimer
JakobJingleheimer requested changes Jan 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tidy!

It's still missing handling for transformRequest, transformResponse, paramsSerializer, etc, which was the blocker before. It needs to either

  • support them
  • detect them and abort/fail the migration

Doing neither will result in broken userland code.

@JakobJingleheimer JakobJingleheimer added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Jan 25, 2026
avivkeller
avivkeller reviewed Feb 2, 2026
View reviewed changes
Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts Outdated
@AugustinMauroy AugustinMauroy force-pushed the feat/axios-to-whatwg-fetch branch from d1ae93f to 469e199 Compare April 6, 2026 07:33
@AugustinMauroy AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Apr 6, 2026
@AugustinMauroy
Copy link
Copy Markdown
Member Author

AugustinMauroy commented Apr 6, 2026

@JakobJingleheimer applied your proposal

JakobJingleheimer
JakobJingleheimer approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts Outdated
Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts Outdated
Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts
Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts Outdated
Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts Outdated
Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts Outdated
Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts Outdated
Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts Outdated
Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts
Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts
},
},
{
oldBind: '$.request',
Copy link
Copy Markdown
Member

@JakobJingleheimer JakobJingleheimer Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh 🤦 👍

I think still better to errorWithLocation (because something failed).

@JakobJingleheimer JakobJingleheimer removed the awaiting reviewer Author has responded and needs action from the reviewer label Apr 23, 2026
@AugustinMauroy AugustinMauroy added the g2g No outstanding concerns, discussions, or issues. label Apr 29, 2026
@AugustinMauroy AugustinMauroy changed the title feat(axios-to-whatwg-fetch): introduce feat(axios-to-whatwg-fetch): introduce Apr 29, 2026
@AugustinMauroy AugustinMauroy merged commit 9cd0fda into main Apr 30, 2026
9 of 10 checks passed
@AugustinMauroy AugustinMauroy deleted the feat/axios-to-whatwg-fetch branch April 30, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller left review comments

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@brunocroh brunocroh brunocroh approved these changes

Assignees

No one assigned

Labels

g2g No outstanding concerns, discussions, or issues.

Projects

Userland Migrations Board
Status: 🏗 In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(axios-to-whatwg-fetch)

4 participants

@AugustinMauroy @JakobJingleheimer @brunocroh @avivkeller