Skip to content

fix(websocket): support process.unref - #5578

Merged
mcollina merged 1 commit into
mainfrom
fix/websocket-process-unref
Jul 28, 2026
Merged

fix(websocket): support process.unref#5578
mcollina merged 1 commit into
mainfrom
fix/websocket-process-unref

Conversation

@mcollina

Copy link
Copy Markdown
Member

Fixes #5570.

Adds Refable protocol support to WebSocket.

Tests: npm run test:websocket

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter

codecov-commenter commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.46%. Comparing base (f36ea9c) to head (80a8d5c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/web/websocket/websocket.js 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5578      +/-   ##
==========================================
- Coverage   93.47%   93.46%   -0.01%     
==========================================
  Files         110      110              
  Lines       37564    37586      +22     
==========================================
+ Hits        35114    35131      +17     
- Misses       2450     2455       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KhafraDev

Copy link
Copy Markdown
Member

😑

@mcollina
mcollina requested review from metcoder95 and ronag July 27, 2026 13:55
@mcollina
mcollina merged commit 1089808 into main Jul 28, 2026
67 of 68 checks passed
@mcollina
mcollina deleted the fix/websocket-process-unref branch July 28, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebSocket.close() orderly TLS shutdown can pin process exit for many seconds; need terminate()/unref

6 participants