Skip to content

src: don't compare kv results#915

Merged
flakey5 merged 1 commit intomainfrom
flakey5/20260419/fix
Apr 19, 2026
Merged

src: don't compare kv results#915
flakey5 merged 1 commit intomainfrom
flakey5/20260419/fix

Conversation

@flakey5
Copy link
Copy Markdown
Member

@flakey5 flakey5 commented Apr 19, 2026

No description provided.

@flakey5 flakey5 requested a review from a team as a code owner April 19, 2026 21:20
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 19, 2026

PR Summary

Low Risk
Low risk: removes a background KV-vs-S3 directory listing comparison and its Sentry reporting without changing the primary readDirectory behavior.

Overview
Removes the temporary background check in R2Provider.readDirectory that compared the resolved directory listing against KvProvider and reported mismatches/errors to Sentry.

The provider now simply returns the cached/S3 result (or KV when USE_KV is enabled) without any asynchronous verification side effects.

Reviewed by Cursor Bugbot for commit 4d66dae. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f7b34d0. Configure here.

Comment thread src/providers/r2Provider.ts
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5 flakey5 force-pushed the flakey5/20260419/fix branch from f7b34d0 to 4d66dae Compare April 19, 2026 21:22
@flakey5 flakey5 merged commit a829d44 into main Apr 19, 2026
7 checks passed
@flakey5 flakey5 deleted the flakey5/20260419/fix branch April 19, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants