Skip to content

src: compare r2 & kv listing results better#910

Closed
flakey5 wants to merge 1 commit intomainfrom
flakey5/20260419/better-kv-comparison
Closed

src: compare r2 & kv listing results better#910
flakey5 wants to merge 1 commit intomainfrom
flakey5/20260419/better-kv-comparison

Conversation

@flakey5
Copy link
Copy Markdown
Member

@flakey5 flakey5 commented Apr 19, 2026

No description provided.

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5 flakey5 requested a review from a team as a code owner April 19, 2026 20:19
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 19, 2026

PR Summary

Low Risk
Changes are limited to background validation/logging of directory listings and should not affect request behavior, but could increase Sentry noise if ordering or metadata differs unexpectedly.

Overview
Tightens the temporary R2Provider.readDirectory cross-check between the S3/cached listing and KvProvider by replacing a full JSON.stringify equality check with targeted validations.

The comparison now handles missing directories explicitly and reports more specific mismatches (hasIndexHtmlFile, subdirectory lists, file count, and per-file name/size), while implicitly tolerating minor lastModified timestamp differences.

Reviewed by Cursor Bugbot for commit 0095ec1. Bugbot is set up for automated code reviews on this repo. Configure here.

@flakey5
Copy link
Copy Markdown
Member Author

flakey5 commented Apr 19, 2026

requesting fast track so we can get actually accurate errors on if there's any significant mismatch between r2 & kv

@flakey5 flakey5 closed this Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant