Skip to content

chore: update redirect links#907

Merged
nodejs-github-bot merged 1 commit intomainfrom
update-redirect-links
Apr 19, 2026
Merged

chore: update redirect links#907
nodejs-github-bot merged 1 commit intomainfrom
update-redirect-links

Conversation

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

No description provided.

@nodejs-github-bot nodejs-github-bot requested a review from a team as a code owner April 19, 2026 19:59
@nodejs-github-bot nodejs-github-bot merged commit c751cbf into main Apr 19, 2026
1 check passed
@nodejs-github-bot nodejs-github-bot deleted the update-redirect-links branch April 19, 2026 19:59
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 19, 2026

PR Summary

Low Risk
Low risk data-only update to the generated cachedDirectories.json used for directory listing caching; main risk is incorrect directory metadata causing stale/missed caching for some paths.

Overview
Updates the generated cachedDirectories.json manifest used to cache directory listings.

The change expands the nodejs/docs/ cached subdirectory list (adding early v0.0.x/v0.1.x entries) and adjusts metadata timestamps, including normalizing nodejs/docs/ lastModified to the epoch and updating many file lastModified values to include millisecond precision.

Reviewed by Cursor Bugbot for commit 66f6fdb. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 66f6fdb. Configure here.

"hasIndexHtmlFile": false,
"files": [],
"lastModified": "2026-04-16T07:15:27.984Z"
"lastModified": "1970-01-01T00:00:00.000Z"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directory lastModified reset to Unix epoch zero

Medium Severity

The lastModified for the nodejs/docs/ directory entry changed from a valid timestamp ("2026-04-16T07:15:27.984Z") to the Unix epoch ("1970-01-01T00:00:00.000Z"). This value is used in R2Provider.readDirectory to construct a Date object for the ReadDirectoryResult, which likely flows into HTTP Last-Modified headers. Serving Thu, 01 Jan 1970 00:00:00 GMT as the last modified date for this directory listing is almost certainly incorrect and could break caching behavior for clients.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 66f6fdb. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants