Skip to content

fix(BasePagination): fix pagination list item vertical alignment (8639)#8640

Open
mertssmnoglu wants to merge 3 commits intonodejs:mainfrom
mertssmnoglu:fix-pagination-v-alignment
Open

fix(BasePagination): fix pagination list item vertical alignment (8639)#8640
mertssmnoglu wants to merge 3 commits intonodejs:mainfrom
mertssmnoglu:fix-pagination-v-alignment

Conversation

@mertssmnoglu
Copy link

Description

Added a .listItemWrapper CSS class that resets margin-top with mt-0! to override the global rule.

Validation

Old

Dark theme

Screenshot_20260218_200926

Light theme

Screenshot_20260218_200935

New

Dark theme

Screenshot_20260218_201521

Light theme

Screenshot_20260218_201530

Related Issues

Addresses #8639

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Mert Şişmanoğlu <mertssmnoglu@gmail.com>
Copilot AI review requested due to automatic review settings February 18, 2026 17:30
@mertssmnoglu mertssmnoglu requested a review from a team as a code owner February 18, 2026 17:30
@vercel
Copy link

vercel bot commented Feb 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Feb 19, 2026 6:12pm

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes inconsistent vertical alignment of BasePagination items by locally overriding a global list-item top-margin rule that was affecting pagination list elements on the blog page.

Changes:

  • Add a wrapper class to the pagination <li> element.
  • Introduce a CSS module rule to reset margin-top on pagination list items.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/ui-components/src/Common/BasePagination/PaginationListItem/index.tsx Applies a new wrapper class to the <li> element in pagination items.
packages/ui-components/src/Common/BasePagination/PaginationListItem/index.module.css Adds .listItemWrapper to override leaked global list spacing impacting pagination alignment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Mert Şişmanoğlu <mertssmnoglu@gmail.com>
Copy link
Member

@araujogui araujogui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, although this bug must be new, cause it wasn't there before 😅

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.11%. Comparing base (5590b5a) to head (8033c2f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8640   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files         104      104           
  Lines        9094     9094           
  Branches      314      314           
=======================================
  Hits         6831     6831           
  Misses       2261     2261           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mert Şişmanoğlu <mertssmnoglu@gmail.com>
@mertssmnoglu
Copy link
Author

Applied same visual fix with a one-liner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments