Repository navigation
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
inoway46
marked this pull request as ready for review
November 8, 2026 05:05
Use ubuntu-latest for CodeQL, documentation, both tarball jobs, lint-cpp and format-cpp in public repositories after observing timeouts on ubuntu-slim. Keep around 30 other jobs on ubuntu-slim, and retain ubuntu-slim in private repositories to avoid increasing runner costs. Refs: nodejs#66409 Refs: nodejs#61663 Refs: nodejs#64972 Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
inoway46
force-pushed
the
public-ci-runners
branch
from
November 8, 2026 05:08
1b0baed to
2391fdf
Compare
Contributor
Author
|
CodeQL's C++ job still took over two hours in |
Contributor
|
CodeQL aside, I don't think the small amount of timeouts is enough to justify deviating private from public. The more we deviate, the less we'll be able to notice if we break something on one repo or the other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #66409, use
ubuntu-latestfor the following jobs in public repositories. Timeout counts over the 30 days ending November 8, 2026:These jobs hit the 15-minute limit discussed in #64972. Around 30 other jobs remain on
ubuntu-slim, preserving the resource-saving intent of #61663. Private repositories continue usingubuntu-slimto avoid increasing runner costs.Validation: