Repository navigation
Conversation
The `skip` option is documented as "If truthy, the test is skipped", but values such as `''`, `0`, `null` and `NaN` marked the test as skipped while its function still ran, because the function is only replaced with a noop when `skip` is truthy. Use a truthiness check for `skipped` so the reported result matches what actually runs. Co-authored-by: Vaishnavi J K <upadyayavaishnavi10@gmail.com> Signed-off-by: jazelly <xzha4350@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67313 +/- ##
==========================================
- Coverage 90.69% 90.69% -0.01%
==========================================
Files 797 797
Lines 279611 279620 +9
Branches 53787 53788 +1
==========================================
Hits 253603 253603
- Misses 16295 16298 +3
- Partials 9713 9719 +6
🚀 New features to boost your workflow:
|
jakecastelli
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR succeeds from #62346
All I did was fixing the CI
Fixes: #61815
Co-Authored-By: @VaishnavIUpadyaya