Skip to content

http: fast-forward teardown of unread messages #65732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcollina wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

http: fast-forward teardown of unread messages #65732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/_http_incoming.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,14 @@ IncomingMessage.prototype._dump = function _dump() {
// If there is buffered data, it may trigger 'data' events.
// Remove 'data' event listeners explicitly.
this.removeAllListeners('data');
this.resume();
if (this.complete && !this.destroyed && this.readableLength === 0) {
// The message was fully received and never read: there is nothing to
// pull off the wire. Go straight to the 'end' emission instead of
// paying for the resume() and flow() scheduling machinery.
this.read(0);
} else {
this.resume();
}
}
};

Expand Down
Loading