src: avoid use-after-close of delayed task scheduler async handle#64492
Open
PickBas wants to merge 1 commit into
Open
src: avoid use-after-close of delayed task scheduler async handle#64492PickBas wants to merge 1 commit into
PickBas wants to merge 1 commit into
Conversation
Fixes: nodejs#64322 Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com> Co-authored-by: Kirill Saied <sayed.kirill@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64492 +/- ##
==========================================
- Coverage 90.25% 90.23% -0.02%
==========================================
Files 741 741
Lines 241216 241692 +476
Branches 45442 45552 +110
==========================================
+ Hits 217713 218101 +388
- Misses 15079 15101 +22
- Partials 8424 8490 +66
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: avoid use-after-close of delayed task scheduler async handle
A worker thread posting a delayed task while the platform is shutting down could call
uv_async_send()on the scheduler's async handle afterStop()began closing it, aborting withAssertion failed: !(handle->flags & UV_HANDLE_CLOSING).This adds a
stopped_flag, guarded by the existing task queue lock, so latePostDelayedTask()calls are dropped instead of racing the handle close. Includes a cctest reproducing the shutdown race.Fixes: #64322