Skip to content

test: wait for ok before initial break after restart#62807

Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-flaky-wait-after-restart
Open

test: wait for ok before initial break after restart#62807
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-flaky-wait-after-restart

Conversation

@inoway46
Copy link
Copy Markdown
Contributor

@inoway46 inoway46 commented Apr 18, 2026

Follow-up to: #62471

Waiting for Debugger attached. before waitForInitialBreak() reduced one race, but it still was not a strong enough sync point. During reconnect, debug> can be re-displayed before the CLI finishes run()/restart(), and the output can still look like:

Debugger attached.
debug>
ok
debug>

This change waits for ok before waitForInitialBreak(), so the test only starts waiting for the initial break after the CLI has completed reconnecting.

CI logs

Testing

UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`"
mkdir -p "$UNUSUAL"
ln -sfn "$PWD" "$UNUSUAL/node"
cd "$UNUSUAL/node"
  • ./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-run-after-quit-restart

Refs: #61762

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 18, 2026
@inoway46 inoway46 marked this pull request as ready for review April 19, 2026 04:02
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (58a8e1d) to head (3a7bcb0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62807      +/-   ##
==========================================
- Coverage   89.69%   89.68%   -0.01%     
==========================================
  Files         706      706              
  Lines      218222   218222              
  Branches    41768    41779      +11     
==========================================
- Hits       195731   195712      -19     
- Misses      14411    14414       +3     
- Partials     8080     8096      +16     

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants