Skip to content

test_runner: add getTestContext() public API#62501

Open
MoLow wants to merge 1 commit intomainfrom
expose-global-get-test-context
Open

test_runner: add getTestContext() public API#62501
MoLow wants to merge 1 commit intomainfrom
expose-global-get-test-context

Conversation

@MoLow
Copy link
Copy Markdown
Member

@MoLow MoLow commented Mar 30, 2026

Exposes getTestContext() function to access test context information from within tests and async operations.

My use case was exposing a pino logger that writes to test diagnostics, but there can be many other usecases:

import { prettyFactory } from 'pino-pretty';

const pretty = prettyFactory({ colorize: true  });
const asyncId = executionAsyncId();
const t = testResources.get(asyncId);
t.diagnostic(pretty(obj).replace(/\n$/, ''));

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 30, 2026
@MoLow MoLow force-pushed the expose-global-get-test-context branch 2 times, most recently from 5aaa29d to 3e9232b Compare March 30, 2026 10:21
@atlowChemi atlowChemi added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 30, 2026
@MoLow MoLow force-pushed the expose-global-get-test-context branch from 3e9232b to 28d1af6 Compare March 30, 2026 10:39
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.71%. Comparing base (d9645d7) to head (28d1af6).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/harness.js 65.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62501      +/-   ##
==========================================
+ Coverage   89.69%   89.71%   +0.01%     
==========================================
  Files         692      692              
  Lines      214039   214061      +22     
  Branches    41064    41066       +2     
==========================================
+ Hits       191985   192037      +52     
+ Misses      14134    14098      -36     
- Partials     7920     7926       +6     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.80% <100.00%> (+<0.01%) ⬆️
lib/test.js 100.00% <100.00%> (ø)
lib/internal/test_runner/harness.js 86.14% <65.00%> (-0.99%) ⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 30, 2026
Copy link
Copy Markdown
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be used by malicious code to behave well in tests, and then behave badly in prod. it'd be different if it was like t.getContext(), though, because malicious code wouldn't have access to t. As it is, it feels like an implicit global communications channel, and those are not advisable.

Only requesting changes to ensure that with multiple stamps, it doesn't land until this item is discussed.

@ljharb ljharb removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants