Open
Conversation
Collaborator
|
Review requested:
|
5aaa29d to
3e9232b
Compare
benjamingr
approved these changes
Mar 30, 2026
atlowChemi
approved these changes
Mar 30, 2026
atlowChemi
reviewed
Mar 30, 2026
3e9232b to
28d1af6
Compare
atlowChemi
approved these changes
Mar 30, 2026
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62501 +/- ##
==========================================
+ Coverage 89.69% 89.71% +0.01%
==========================================
Files 692 692
Lines 214039 214061 +22
Branches 41064 41066 +2
==========================================
+ Hits 191985 192037 +52
+ Misses 14134 14098 -36
- Partials 7920 7926 +6
🚀 New features to boost your workflow:
|
ljharb
requested changes
Mar 31, 2026
Member
ljharb
left a comment
There was a problem hiding this comment.
I think this could be used by malicious code to behave well in tests, and then behave badly in prod. it'd be different if it was like t.getContext(), though, because malicious code wouldn't have access to t. As it is, it feels like an implicit global communications channel, and those are not advisable.
Only requesting changes to ensure that with multiple stamps, it doesn't land until this item is discussed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
getTestContext()function to access test context information from within tests and async operations.My use case was exposing a pino logger that writes to test diagnostics, but there can be many other usecases: