deps: ignore loopback interface in c-ares on Windows#62413
Open
kairosci wants to merge 1 commit intonodejs:mainfrom
Open
deps: ignore loopback interface in c-ares on Windows#62413kairosci wants to merge 1 commit intonodejs:mainfrom
kairosci wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
cares
Author
|
Also proposed in c-ares/c-ares#1095 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
deps/caresto ignore DNS servers reported by the loopback interface on Windows.This prevents
dns.getServers()from returning127.0.0.1when it is not explicitly configured on a physical interface.Fixes: #62347
For code changes:
make -j4 test(UNIX), orvcbuild test(Windows) passes.