Skip to content

Fix add dict.items() in dictionary iteration#341

Merged
cclauss merged 1 commit intomainfrom
dict.items
Apr 21, 2026
Merged

Fix add dict.items() in dictionary iteration#341
cclauss merged 1 commit intomainfrom
dict.items

Conversation

@cclauss
Copy link
Copy Markdown
Contributor

@cclauss cclauss commented Apr 21, 2026

Fix for Windows test blocking:

BEGIN_COMMIT_OVERRIDE
fix: add dict.items() in dictionary iteration (#341)
END_COMMIT_OVERRIDE

Fix for Windows test blocking:
* nodejs/node-gyp#/3295
cclauss referenced this pull request Apr 21, 2026
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss cclauss merged commit f7085ce into main Apr 21, 2026
115 of 116 checks passed
@cclauss cclauss deleted the dict.items branch April 21, 2026 07:07
@gengjiawen
Copy link
Copy Markdown
Member

commit msg should be follow conventional commit, otherwise it won't be in the changelog :)

@cclauss
Copy link
Copy Markdown
Contributor Author

cclauss commented Apr 21, 2026

Sorry but I contribute to too many repos to consistently follow all their various commit conventions if they are not enforced. Thank for your reviews and support.

@legendecas
Copy link
Copy Markdown
Member

legendecas commented Apr 21, 2026

@gengjiawen @cclauss we can use the following format in the PR body to fixup the message, by re-run the release-please workflow (this amendament should be done before merging the release PR):

BEGIN_COMMIT_OVERRIDE
fix: add dict.items() in dictionary iteration (https://github.com/nodejs/gyp-next/pull/341)
END_COMMIT_OVERRIDE

I did it in #338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants