Skip to content
This repository was archived by the owner on Jun 22, 2024. It is now read-only.
This repository was archived by the owner on Jun 22, 2024. It is now read-only.

fake-names-generator : Names generated in console are different from ones saved in file #35

Description

@senechalloic

Thanks for this repository, I'm learning NodeJs and this helps me.

Issue

I think there is a small issue in project cli/commander/fake-names-generator.
When we choose to save the names, the display names are different than the one shown in the console.

RootCause

I think the issue come from logNames() and saveNames() that generate two times the names in cli\commander\fake-names-generator\bin\cli.js.

Possible solution

logNames() could return the generated names and pass it to saveNames().

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions