Repository navigation
build,win: allow opting out of JS test subsets - #4556
Open
StefanStojanovic wants to merge 1 commit into
Open
StefanStojanovic wants to merge 1 commit into
StefanStojanovic wants to merge 1 commit into
Conversation
Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Contributor
Author
Not this branch exactly, but my WIP PGO test job, uses a branch that has this commit, which basically does the same thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to stop using 4 subsets for JS tests on Windows. This is an idea I've discussed with @sxa previously, and we determined it was worth trying out. With this fix, if
NODES_SUBSETis removed from the JS test configuration, it would fall back to using a single executor for all of the tests.