Skip to content

Adding example in NI-DC Power , NI-DMM , NI-Switch - #2192

Open
bkumarng-NI wants to merge 4 commits into
ni:masterfrom
bkumarng-NI:master
Open

Adding example in NI-DC Power , NI-DMM , NI-Switch#2192
bkumarng-NI wants to merge 4 commits into
ni:masterfrom
bkumarng-NI:master

Conversation

@bkumarng-NI

@bkumarng-NI bkumarng-NI commented Aug 11, 2026

Copy link
Copy Markdown

What does this Pull Request accomplish?

  • One additional example added in dcpower, dmm and switch drivers.
  • nidcpower_hardware_timed_single_point.py, nidmm_triggered_fetch_waveform.py, niswitch_software_scanning.py
  • Update CHANGELOG.md to call out the new examples in unreleased section.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

  • tox completed successfully.
  • pytest src/nidmm/system_tests -c generated/nidmm/tox-system_tests.ini
  • pytest src/nidcpower/system_tests -c generated/nidcpower/tox-system_tests.ini
  • pytest src/niswitch/system_tests -c generated/niswitch/tox-system_tests.ini

Adding one new example each in NI-DMM, NI-DCPower, and NI-SWITCH.
updated CHANGELOG.md to include additional examples added in nidcpower, nidmm, niswitch in "unreleased section.
@codecov-commenter

codecov-commenter commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.10%. Comparing base (5387cd9) to head (7a997bc).

❗ There is a different number of reports uploaded between BASE (5387cd9) and HEAD (7a997bc). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (5387cd9) HEAD (7a997bc)
nimodinstsystemtests 1 0
nisesystemtests 1 0
niswitchsystemtests 1 0
nidmmsystemtests 1 0
niscopesystemtests 1 0
nidigitalsystemtests 1 0
nirfsgsystemtests 1 0
nifgensystemtests 1 0
nidcpowersystemtests 1 0
nitclksystemtests 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2192      +/-   ##
==========================================
- Coverage   89.32%   82.10%   -7.22%     
==========================================
  Files          73       29      -44     
  Lines       19048     4163   -14885     
==========================================
- Hits        17014     3418   -13596     
+ Misses       2034      745    -1289     
Flag Coverage Δ
codegenunittests 84.90% <ø> (ø)
nidcpowersystemtests ?
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests ?
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests ?
nifakeunittests 86.01% <ø> (ø)
nifgensystemtests ?
nimodinstsystemtests ?
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests ?
niscopesystemtests ?
niscopeunittests 43.20% <ø> (ø)
nisesystemtests ?
niswitchsystemtests ?
nitclksystemtests ?
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 48 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5387cd9...7a997bc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni-jfitzger

Copy link
Copy Markdown
Collaborator

Summary
Added a new NI-DMM example.

Added a new NI-DCPower example.

Added a new NI-SWITCH example.

This contribution adheres to CONTRIBUTING.md

I've updated CHANGELOG.md.

Please stick to the pull request template.

- [ ] This contribution adheres to [CONTRIBUTING.md](https://github.com/ni/nimi-python/blob/master/CONTRIBUTING.md).
- [ ] I've updated [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md) if applicable.
- [ ] I've added tests applicable for this pull request

Include all 3, place an X to fill in the checkbox, where appropriate, and strikethrough anything that doesn't apply.
Details about your changes can go in the "What does this Pull Request accomplish?" section.

@ni-jfitzger ni-jfitzger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run tox -e codegen to regenerate the examples documentation and then commit the change, so that Travis CI won't fail.

@bkumarng-NI

Copy link
Copy Markdown
Author

You need to run tox -e codegen to regenerate the examples documentation and then commit the change, so that Travis CI won't fail.
I have ran tox -e codegen` and "Travis CI " is passing now. Also updated the PR details as per template. Kindly let me know if still any concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants